You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 18:06:51 UTC
[GitHub] [superset] nikolagigic opened a new pull request #12413: chore(chart): Save modal select placeholder value
nikolagigic opened a new pull request #12413:
URL: https://github.com/apache/superset/pull/12413
### SUMMARY
Fix SaveModal dashboard select placeholder value and clear button.
https://github.com/apache/superset/issues/12366
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TEST PLAN
1. **Open** or **create** any chart
2. Click on **Save** button to save the chart
**Expected result**: Under **ADD TO DASHBOARD** label, select dropdown should have a placeholder text with no clear button. If the value is selected, the value should be displayed instead of placeholder and clear button should appear.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12413:
URL: https://github.com/apache/superset/pull/12413#discussion_r555298958
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -29,7 +29,7 @@ import { connect } from 'react-redux';
// Session storage key for recent dashboard
const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
-const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');
+const SELECT_PLACEHOLDER = t('Select dashboard');
Review comment:
Have we removed that functionality?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `7.93%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 58.95% -7.94%
==========================================
Files 1014 959 -55
Lines 49513 46858 -2655
Branches 5077 4355 -722
==========================================
- Hits 33118 27626 -5492
- Misses 16264 19232 +2968
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.99% <0.00%> (+0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.45% <ø> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `81.01% <0.00%> (-9.58%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [432 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
adam-stasiak edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758188770
I have a behavior where when I add new chart and try to save it is automatically selected first dashboard from list:
https://user-images.githubusercontent.com/25153919/104231907-e3724b00-544f-11eb-9e4b-7ccc1d1c6c0b.mov
I guess it should not be chosen by default to avoid mistakes. In previous releases it was not proposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.44%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.44% -0.45%
==========================================
Files 1014 1015 +1
Lines 49513 49637 +124
Branches 5077 4972 -105
==========================================
- Hits 33118 32980 -138
- Misses 16264 16534 +270
+ Partials 131 123 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.99% <0.00%> (+0.01%)` | :arrow_up: |
| javascript | `60.74% <100.00%> (+0.03%)` | :arrow_up: |
| python | `63.44% <ø> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `91.01% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (-4.83%)` | :arrow_down: |
| ... and [72 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `7.93%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 58.95% -7.94%
==========================================
Files 1014 959 -55
Lines 49513 46873 -2640
Branches 5077 4355 -722
==========================================
- Hits 33118 27633 -5485
- Misses 16264 19240 +2976
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.99% <0.00%> (+0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.44% <ø> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `81.01% <0.00%> (-9.58%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [427 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.76% -0.13%
==========================================
Files 1014 1015 +1
Lines 49513 49644 +131
Branches 5077 4972 -105
==========================================
+ Hits 33118 33144 +26
- Misses 16264 16377 +113
+ Partials 131 123 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.01% <0.00%> (+0.03%)` | :arrow_up: |
| javascript | `60.74% <100.00%> (+0.03%)` | :arrow_up: |
| python | `63.96% <ø> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `91.01% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (-4.83%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `58.90% <0.00%> (-4.48%)` | :arrow_down: |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `83.78% <0.00%> (-4.46%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `70.96% <0.00%> (-4.04%)` | :arrow_down: |
| ... and [69 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.75% -0.13%
==========================================
Files 1014 1015 +1
Lines 49513 49637 +124
Branches 5077 4972 -105
==========================================
+ Hits 33118 33137 +19
- Misses 16264 16377 +113
+ Partials 131 123 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.99% <0.00%> (+0.01%)` | :arrow_up: |
| javascript | `60.74% <100.00%> (+0.03%)` | :arrow_up: |
| python | `63.96% <ø> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `91.01% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (-4.83%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `58.90% <0.00%> (-4.48%)` | :arrow_down: |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `83.78% <0.00%> (-4.46%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `70.96% <0.00%> (-4.04%)` | :arrow_down: |
| ... and [69 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.21%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.67% -0.22%
==========================================
Files 1014 1015 +1
Lines 49513 49637 +124
Branches 5077 4972 -105
==========================================
- Hits 33118 33096 -22
- Misses 16264 16418 +154
+ Partials 131 123 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.99% <0.00%> (+0.01%)` | :arrow_up: |
| javascript | `60.74% <100.00%> (+0.03%)` | :arrow_up: |
| python | `63.83% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `91.01% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-9.96%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (-4.83%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `58.90% <0.00%> (-4.48%)` | :arrow_down: |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `83.78% <0.00%> (-4.46%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758133336
🎫 viz:explore:ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758249195
> I guess it should not be chosen by default to avoid mistakes. In previous releases it was not proposed.
When users come from "View chart in Explore" on the dashboard page, the origin dashboard should be selected (so they can click on "Save & Go to Dashboard").
When users edit an existing chart from the Chart List page, the dashboard should not be selected.
(I think this is the current behavior and it's correct.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic closed pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
nikolagigic closed pull request #12413:
URL: https://github.com/apache/superset/pull/12413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12413:
URL: https://github.com/apache/superset/pull/12413#discussion_r555298958
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -29,7 +29,7 @@ import { connect } from 'react-redux';
// Session storage key for recent dashboard
const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
-const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');
+const SELECT_PLACEHOLDER = t('Select dashboard');
Review comment:
Yes and I think we decided to allow users to do that since that's what in the original modal. Have we removed that functionality?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12413:
URL: https://github.com/apache/superset/pull/12413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (11950ef) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.43%`.
> The diff coverage is `78.57%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.44% -0.44%
==========================================
Files 1014 1014
Lines 49513 49587 +74
Branches 5077 5096 +19
==========================================
- Hits 33118 32950 -168
- Misses 16264 16502 +238
- Partials 131 135 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.58% <100.00%> (-0.40%)` | :arrow_down: |
| javascript | `60.71% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `63.73% <76.00%> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/f9a30386bd74\_cleanup\_time\_grainularity.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mOWEzMDM4NmJkNzRfY2xlYW51cF90aW1lX2dyYWludWxhcml0eS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <76.00%> (-25.65%)` | :arrow_down: |
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `92.22% <100.00%> (+1.63%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `38.73% <0.00%> (-24.65%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [.../src/dashboard/components/RefreshIntervalModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLnRzeA==) | `78.18% <0.00%> (-8.67%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...3ccae72](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
adam-stasiak edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758188770
I have a behavior where when I add new chart and try to save it is automatically selected first dashboard from list:
https://user-images.githubusercontent.com/25153919/104231907-e3724b00-544f-11eb-9e4b-7ccc1d1c6c0b.mov
I guess it should not be chosen by default to avoid mistakes. In previous releases it was not proposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #12413:
URL: https://github.com/apache/superset/pull/12413#discussion_r555297760
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -29,7 +29,7 @@ import { connect } from 'react-redux';
// Session storage key for recent dashboard
const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
-const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');
+const SELECT_PLACEHOLDER = t('Select dashboard');
Review comment:
@ktmud but the original text is referring to dashboard creation through save modal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (3ccae72) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `4.19%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 62.69% -4.20%
==========================================
Files 1014 1014
Lines 49513 49507 -6
Branches 5077 5078 +1
==========================================
- Hits 33118 31037 -2081
- Misses 16264 18260 +1996
- Partials 131 210 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.71% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `63.98% <ø> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `86.04% <100.00%> (-4.55%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [206 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...3ccae72](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758249195
> I guess it should not be chosen by default to avoid mistakes. In previous releases it was not proposed.
When users come from "View chart in Explore" on the dashboard page, the origin dashboard should be selected (so they can click on "Save & Go to Dashboard").
When users edit an existing chart from the Chart List page, the dashboard should not be selected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on a change in pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on a change in pull request #12413:
URL: https://github.com/apache/superset/pull/12413#discussion_r555300407
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -29,7 +29,7 @@ import { connect } from 'react-redux';
// Session storage key for recent dashboard
const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
-const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');
+const SELECT_PLACEHOLDER = t('Select dashboard');
Review comment:
It is possible to create a dashboard through this modal and I guess text should claim that creation is possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (3ccae72) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `4.40%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 62.48% -4.41%
==========================================
Files 1014 1014
Lines 49513 49505 -8
Branches 5077 5078 +1
==========================================
- Hits 33118 30934 -2184
- Misses 16264 18361 +2097
- Partials 131 210 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.71% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `63.64% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `86.04% <100.00%> (-4.55%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [208 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...3ccae72](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758188770
I have a behavior where when I add new chart and try to save it is automatically selected first dashboard from list:
https://user-images.githubusercontent.com/25153919/104231907-e3724b00-544f-11eb-9e4b-7ccc1d1c6c0b.mov
I guess it should not be chosen by default to avoid mistakes. In previous releases it was not proposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.76% -0.13%
==========================================
Files 1014 1015 +1
Lines 49513 49644 +131
Branches 5077 4972 -105
==========================================
+ Hits 33118 33144 +26
- Misses 16264 16377 +113
+ Partials 131 123 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.01% <0.00%> (+0.03%)` | :arrow_up: |
| javascript | `60.74% <100.00%> (+0.03%)` | :arrow_up: |
| python | `63.96% <ø> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `91.01% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (-4.83%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `58.90% <0.00%> (-4.48%)` | :arrow_down: |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `83.78% <0.00%> (-4.46%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `70.96% <0.00%> (-4.04%)` | :arrow_down: |
| ... and [69 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mihir174 commented on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
mihir174 commented on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-760452512
thanks for the context @ktmud
Here's a common UI pattern I've seen in many products for this scenario -
<img width="1972" alt="Slice 1 (5)" src="https://user-images.githubusercontent.com/64227069/104644571-c3ff3c00-5662-11eb-8ceb-9800c795297b.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (17834a3) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `8.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 58.84% -8.04%
==========================================
Files 1014 958 -56
Lines 49513 46767 -2746
Branches 5077 4341 -736
==========================================
- Hits 33118 27522 -5596
- Misses 16264 19245 +2981
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.96% <100.00%> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.29% <ø> (-0.92%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `82.89% <100.00%> (-7.70%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| ... and [410 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...3ccae72](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758249195
> I guess it should not be chosen by default to avoid mistakes. In previous releases it was not proposed.
When users come from "View chart in Explore" on the dashboard page, the origin dashboard should be selected (so they can click on "Save & Go to Dashboard").
When users edit an existing chart from the Chart List page, the dashboard should not be selected.
(I think this is current bahvior.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-762379924
Dashboards should now be selected properly and I changed the placeholder text
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758132209
@junlincc @rusackas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12413:
URL: https://github.com/apache/superset/pull/12413#discussion_r555255868
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -29,7 +29,7 @@ import { connect } from 'react-redux';
// Session storage key for recent dashboard
const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
-const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');
+const SELECT_PLACEHOLDER = t('Select dashboard');
Review comment:
Can we keep the original copy as I don't think we've added the functionality to create a dashboard in the dropdown yet.
https://projects.invisionapp.com/share/V5VH03AHBER#/screens/399817652
cc @mihir174
For context, #10355 added this copy and there is a discussion on why this is still not optimal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (cca9364) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.76% -0.13%
==========================================
Files 1014 1015 +1
Lines 49513 49644 +131
Branches 5077 4972 -105
==========================================
+ Hits 33118 33144 +26
- Misses 16264 16377 +113
+ Partials 131 123 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.01% <0.00%> (+0.03%)` | :arrow_up: |
| javascript | `60.74% <100.00%> (+0.03%)` | :arrow_up: |
| python | `63.96% <ø> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `91.01% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (-4.83%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `58.90% <0.00%> (-4.48%)` | :arrow_down: |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `83.78% <0.00%> (-4.46%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `70.96% <0.00%> (-4.04%)` | :arrow_down: |
| ... and [69 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...cca9364](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
nikolagigic edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758133336
🏷️ viz:explore:ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12413: chore(chart): Save modal select placeholder value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12413:
URL: https://github.com/apache/superset/pull/12413#issuecomment-758203375
# [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=h1) Report
> Merging [#12413](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=desc) (3ccae72) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `4.19%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 62.69% -4.20%
==========================================
Files 1014 1014
Lines 49513 49505 -8
Branches 5077 5078 +1
==========================================
- Hits 33118 31035 -2083
- Misses 16264 18260 +1996
- Partials 131 210 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.71% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `63.98% <ø> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `86.04% <100.00%> (-4.55%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [208 more](https://codecov.io/gh/apache/superset/pull/12413/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=footer). Last update [ff7b789...3ccae72](https://codecov.io/gh/apache/superset/pull/12413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org