You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/05 00:45:57 UTC
[GitHub] [spark] xinrong-meng opened a new pull request, #37412: [SPARK-39986][PS][DOC] Better example for Co-grouped Map
xinrong-meng opened a new pull request, #37412:
URL: https://github.com/apache/spark/pull/37412
### What changes were proposed in this pull request?
Currently, Co-grouped Map uses pandas `asof_merge` as an example, which may misguide users since `asof_merge` is supported in Pandas API on Spark.
So unsupported `merge_sorted` is used instead.
### Why are the changes needed?
Better documents.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37412: [SPARK-39986][PS][DOC] Better example for Co-grouped Map
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37412: [SPARK-39986][PS][DOC] Better example for Co-grouped Map
URL: https://github.com/apache/spark/pull/37412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37412: [SPARK-39986][PS][DOC] Better example for Co-grouped Map
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37412:
URL: https://github.com/apache/spark/pull/37412#issuecomment-1205993613
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37412: [SPARK-39986][PS][DOC] Better example for Co-grouped Map
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #37412:
URL: https://github.com/apache/spark/pull/37412#discussion_r938363373
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -1174,4 +1174,4 @@
},
"nbformat": 4,
"nbformat_minor": 1
-}
+}
Review Comment:
thats fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-meng commented on a diff in pull request #37412: [SPARK-39986][PS][DOC] Better example for Co-grouped Map
Posted by GitBox <gi...@apache.org>.
xinrong-meng commented on code in PR #37412:
URL: https://github.com/apache/spark/pull/37412#discussion_r938358437
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -1174,4 +1174,4 @@
},
"nbformat": 4,
"nbformat_minor": 1
-}
+}
Review Comment:
Hmm.. not changed at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org