[GitHub] [beam] svetakvsundhar commented on a diff in pull request #22616: Add initial read_gbq wrapper

[GitBox <gi...@apache.org>]

svetakvsundhar commented on code in PR #22616:
URL: https://github.com/apache/beam/pull/22616#discussion_r942489348


##########
sdks/python/apache_beam/dataframe/io.py:
##########
@@ -58,6 +58,17 @@
 _DEFAULT_BYTES_CHUNKSIZE = 1 << 20
 
 
+@frame_base.with_docs_from(pd)
+def read_gbq(table, *args, **kwargs):
+  """If you would like to use the 'DIRECT_READ' method ins ReadFromBigQuery,
+    please set use_bq_storage_api to True.
+    Otherwise, if you would like to use the 'EXPORT' method, please set
+    use_bq_storage_api to False, or leave it unspecified."""

Review Comment:
   Hm, I disagree. I'm assuming that users that want to ReadFromBQ might already be use to the way the ReadFromBQ PTransform works, and thus it would be useful to let them know how to utilize 'DIRECT_READ' and 'EXPORT' via the ReadGbq PTransform.
   
   What are the benefits of not mentioning 'DIRECT_READ' and 'EXPORT'?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org