You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ti...@sastau.it> on 2007/07/09 08:51:09 UTC

Warning caused by FinAccountTrans.comment field

Hi,

in the FinAccountTrans entity there is a field named "comment"; this 
causes a warning at startup (at least in Derby) because "comment" seems 
to be a reserved word... can we simply change it to "comments".

Should we also change the field's type from long-varchar to comments?

Jacopo


Re: Warning caused by FinAccountTrans.comment field

Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes, why not ?

+1

Jacques

De : "Jacopo Cappellato" <ti...@sastau.it>
> Hi,
> 
> in the FinAccountTrans entity there is a field named "comment"; this 
> causes a warning at startup (at least in Derby) because "comment" seems 
> to be a reserved word... can we simply change it to "comments".
> 
> Should we also change the field's type from long-varchar to comments?
> 
> Jacopo

Re: Warning caused by FinAccountTrans.comment field

Posted by Jacopo Cappellato <ti...@sastau.it>.
I forgot to mention that I've fixed it in rev. 554591

Jacopo

David E Jones wrote:
> 
> Call to all committers: DO NOT COMMIT DATA MODEL CHANGES WITHOUT AT 
> LEAST STARTING OFBIZ TO LET IT DO SOME BASIC CHECKS ON THE ENTITY MODEL.
> 
> 
> Jacopo Cappellato wrote:
>> Hi,
>>
>> in the FinAccountTrans entity there is a field named "comment"; this 
>> causes a warning at startup (at least in Derby) because "comment" 
>> seems to be a reserved word... can we simply change it to "comments".
> 
> The entity engine is probably reporting this as a reserved word at 
> startup. The field name should be changed as "comment" is a reserved 
> word in various databases.
> 
>> Should we also change the field's type from long-varchar to comments?
> 
> Might as well, would be more consistent.
> 
> -David



Re: Warning caused by FinAccountTrans.comment field

Posted by David E Jones <jo...@hotwaxmedia.com>.
Call to all committers: DO NOT COMMIT DATA MODEL CHANGES WITHOUT AT LEAST STARTING OFBIZ TO LET IT DO SOME BASIC CHECKS ON THE ENTITY MODEL.


Jacopo Cappellato wrote:
> Hi,
> 
> in the FinAccountTrans entity there is a field named "comment"; this 
> causes a warning at startup (at least in Derby) because "comment" seems 
> to be a reserved word... can we simply change it to "comments".

The entity engine is probably reporting this as a reserved word at startup. The field name should be changed as "comment" is a reserved word in various databases.

> Should we also change the field's type from long-varchar to comments?

Might as well, would be more consistent.

-David