You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/08 08:06:13 UTC

[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #13070: [Feature][API] New restful API for taskInstance

github-code-scanning[bot] commented on code in PR #13070:
URL: https://github.com/apache/dolphinscheduler/pull/13070#discussion_r1043041141


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceV2Controller.java:
##########
@@ -127,4 +175,27 @@
         Result result = taskInstanceService.forceTaskSuccess(loginUser, projectCode, id);
         return new TaskInstanceSuccessResponse(result);
     }
+
+    /**
+     * query taskInstance by taskInstanceCode
+     *
+     * @param loginUser   login user
+     * @param projectCode project code
+     * @param taskCode          task code

Review Comment:
   ## Spurious Javadoc @param tags
   
   @param tag "taskCode" does not match any actual parameter of method "queryTaskInstanceByCode()".
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2388)



##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskInstanceService.java:
##########
@@ -89,4 +90,14 @@
      * @return
      */
     Result stopTask(User loginUser, long projectCode, Integer taskInstanceId);
+
+    /**
+     * query taskInstance by taskInstanceCode
+     *
+     * @param loginUser   login user
+     * @param projectCode project code
+     * @param taskCode          task instance code

Review Comment:
   ## Spurious Javadoc @param tags
   
   @param tag "taskCode" does not match any actual parameter of method "queryTaskInstanceByCode()".
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2389)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org