[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6920: support /dev/crypto for nuttx

[GitBox <gi...@apache.org>]

gustavonihei commented on code in PR #6920:
URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r982388190


##########
arch/risc-v/src/esp32c3/esp32c3_sha.c:
##########
@@ -668,6 +668,7 @@ void esp32c3_sha1_free(struct esp32c3_sha1_context_s *ctx)
 void esp32c3_sha256_init(struct esp32c3_sha256_context_s *ctx)
 {
   memset(ctx, 0, sizeof(struct esp32c3_sha256_context_s));
+  ctx->mode = ESP32C3_SHA2_256;

Review Comment:
   Could you please do this similar change to the `esp32c3_sha1_init` function?
   ```c
     ctx->mode = ESP32C3_SHA1_1;
   ```
   And remove the `esp32c3_sha256_starts` function which is not currently used in this driver nor present in the driver interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org