You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by "Christophe Le Saec (Jira)" <ji...@apache.org> on 2023/02/13 12:45:00 UTC

[jira] [Commented] (AVRO-3713) Regression AVRO-1760 : Thread scalability problem with the use of SynchronizedMap

    [ https://issues.apache.org/jira/browse/AVRO-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687919#comment-17687919 ] 

Christophe Le Saec commented on AVRO-3713:
------------------------------------------

Approved the PR.
And more, the synchronized map is useless in current code, as get and put are not in a same synchronized block.

> Regression AVRO-1760 : Thread scalability problem with the use of SynchronizedMap
> ---------------------------------------------------------------------------------
>
>                 Key: AVRO-3713
>                 URL: https://issues.apache.org/jira/browse/AVRO-3713
>             Project: Apache Avro
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is a regression of AVRO-1760 which is causing production performance problems.
> In AVRO-1760 the issue was fixed that there is a scalability problem with AVRO being used in multithreaded situations.
> The solution that was implemented for this ticket uses a different Map implementation (part of Guava) that does not have these locking issues:
> [https://github.com/apache/avro/commit/363360229e7ea5f816d87f9d5747dd4494d3b862#diff-422f44890f5e0ab1f508a7c75d0d18fc7831a1c3ca13e0c97780617570c50d5cL970-L973]
> Investigating the performance of our internal application has made us conclude the original problem was reintroduced with this commit:
> [https://github.com/apache/avro/commit/c78a3d5ea4e7e511ba9f6182157956db3e65e1a0#diff-422f44890f5e0ab1f508a7c75d0d18fc7831a1c3ca13e0c97780617570c50d5cL986-L988]
> which seems to be related to this jira AVRO-2265 "Remove Guava as a dependency".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)