You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2020/11/07 17:49:45 UTC

[GitHub] [tomee] rmannibucau commented on pull request #716: TOMEE-2917 - Change All WrappingMessage to become serializable

rmannibucau commented on pull request #716:
URL: https://github.com/apache/tomee/pull/716#issuecomment-723474443


   Maybe a trivial test case ensuring it is actually serializable is worth it, something around https://github.com/apache/tomee/blob/master/container/openejb-core/src/test/java/org/apache/openejb/util/proxy/LocalBeanProxySerializationTest.java in https://github.com/apache/tomee/blob/master/container/openejb-core/src/test/java/org/apache/openejb/activemq/JMS2AMQTest.java (to reuse jms setup) looks not that hard and will prevent regressions at very least.
   
   side note to tomee committers: got in touch with some amq guys and amq (5) should get JMS 2 support so all this code can be dropped at some point (tomee can also push it to amq to make it happen faster).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org