You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/08/12 21:48:28 UTC

Review Request 68312: AttributeDef Update: Support for Soft Reference

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_


**Usage**
See attached JSON.


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
  repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
  repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 


Diff: https://reviews.apache.org/r/68312/diff/1/


Testing
-------

**Unit tests**
Additional tests.


File Attachments
----------------

rdbms-db.json
  https://reviews.apache.org/media/uploaded/files/2018/08/12/1f45deeb-55d7-4c68-8640-ca184cf08a2c__rdbms-db.json


Thanks,

Ashutosh Mestry

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207162
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java
Lines 421 (patched)
<https://reviews.apache.org/r/68312/#comment290457>

    also check if the value of the map key is 'true'. isSoftReference=true


- Sarath Subramanian


On Aug. 13, 2018, 10:31 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:31 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
>   repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
>   repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/2/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207186
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java
Lines 421 (patched)
<https://reviews.apache.org/r/68312/#comment290480>

    public boolean isSoftReferenced() {
      String strValue = options != null ? options.get(AtlasAttributeDef.ATTRDEF_OPTION_SOFT_REFERENCE) : null;
    
      return Boolean.parseBoolean(strValue);
    }
    
    Does this method add a boolean field named "softReferenced" in AtlasAttributeDef? If yes, we should comeup with a different name (that doesn't start with get/set/is) or a method that takes a parameter.



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 346 (patched)
<https://reviews.apache.org/r/68312/#comment290481>

    - when 'null' is sent as new value shouldn't existing value in vertex property be removed/updated?
    - when the given value is not AtlasObjectId, it will help to create a WARN log


- Madhan Neethiraj


On Aug. 13, 2018, 9:52 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 9:52 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b6d82dd834b8cc8b3bac630c084b91ac34dd0cec 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
>   repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
>   repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/3/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> **Functional tests**
> - Quick Start
> - Entity creation via REST APIs.
> - Entity creation via APIs.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207181
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Aug. 13, 2018, 2:52 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 2:52 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b6d82dd834b8cc8b3bac630c084b91ac34dd0cec 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
>   repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
>   repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/3/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> **Functional tests**
> - Quick Start
> - Entity creation via REST APIs.
> - Entity creation via APIs.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207378
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 15, 2018, 10:58 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2018, 10:58 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b32c092557b845482a50ca302e102f0b69c8b860 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 381191986df81d691e2598d4760d7999344dc630 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 81b553e6efa60fee3fc75334b3c9da8611d41a9d 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java 856f38347ea83d95b7095ac40f39c51dbd869d05 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/6/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> **Functional tests**
> - Quick Start
> - Entity creation via REST APIs.
> - Entity creation via APIs.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 15, 2018, 10:58 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Updates include:
- Addressed review comments.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b32c092557b845482a50ca302e102f0b69c8b860 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 381191986df81d691e2598d4760d7999344dc630 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 81b553e6efa60fee3fc75334b3c9da8611d41a9d 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java 856f38347ea83d95b7095ac40f39c51dbd869d05 


Diff: https://reviews.apache.org/r/68312/diff/6/

Changes: https://reviews.apache.org/r/68312/diff/5-6/


Testing
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.

**Functional tests**
- Quick Start
- Entity creation via REST APIs.
- Entity creation via APIs.


File Attachments
----------------

rdbms-db.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
typesDef-soft-ref.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207275
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Line 506 (original), 506 (patched)
<https://reviews.apache.org/r/68312/#comment290605>

    Move creation of 'objectIds' list from line #506 to #511.



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Line 514 (original), 518 (patched)
<https://reviews.apache.org/r/68312/#comment290606>

    objectId could be null here, due to line #527, #541 below. Please handle this case, just as in line #497 above.


- Madhan Neethiraj


On Aug. 14, 2018, 10:50 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2018, 10:50 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b32c09255 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 381191986 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 81b553e6e 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java 856f38347 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/5/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> **Functional tests**
> - Quick Start
> - Entity creation via REST APIs.
> - Entity creation via APIs.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 14, 2018, 10:50 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Updates include:
- Handled delete from list attribute.
- Handled delete from map attribute.
- Additional unit tests to verify delete and udpate in collection.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b32c09255 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 381191986 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 81b553e6e 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java 856f38347 


Diff: https://reviews.apache.org/r/68312/diff/5/

Changes: https://reviews.apache.org/r/68312/diff/4-5/


Testing
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.

**Functional tests**
- Quick Start
- Entity creation via REST APIs.
- Entity creation via APIs.


File Attachments
----------------

rdbms-db.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
typesDef-soft-ref.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207198
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 353 (patched)
<https://reviews.apache.org/r/68312/#comment290496>

    Instead of updating 'ctx' and calling mapPrimitiveValue(ctx), it will be cleaner to simply call the following from here:
    
            AtlasGraphUtilsV1.setProperty(ctx.getReferringVertex(), ctx.getVertexProperty(), softRefValue);
            
    
    Also, after above update, remove method AttributeMutationContext.setValue().



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Line 767 (original), 790 (patched)
<https://reviews.apache.org/r/68312/#comment290497>

    How are the 'removed' map entries cleaned up in case of 'softReferences'?



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Line 852 (original), 875 (patched)
<https://reviews.apache.org/r/68312/#comment290498>

    How are the 'removed' array elements cleaned up in case of 'softReferences'?



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 481 (patched)
<https://reviews.apache.org/r/68312/#comment290489>

    consider changing return type from "Object" to "Map<String, AtlasObjectId>"



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 505 (patched)
<https://reviews.apache.org/r/68312/#comment290490>

    consider changing return type from "Object" to "List<AtlasObjectId>"



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 508 (patched)
<https://reviews.apache.org/r/68312/#comment290492>

    Consider handling 'list == null' here (similar to line #483 above)?



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 520 (patched)
<https://reviews.apache.org/r/68312/#comment290491>

    consider changing return type from "Object" to "AtlasObjectId"



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 522 (patched)
<https://reviews.apache.org/r/68312/#comment290493>

    Consider handling 'rawValue == null' here (similar to line #483 above)?



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 526 (patched)
<https://reviews.apache.org/r/68312/#comment290494>

    Consider handling 'rawValue == null' here (similar to line #483 above)?



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 528 (patched)
<https://reviews.apache.org/r/68312/#comment290495>

    Consider adding a WARN log here.


- Madhan Neethiraj


On Aug. 14, 2018, 12:02 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2018, 12:02 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 9dba1c06fa5548470056cf8cf095f3d2744650b0 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 381191986df81d691e2598d4760d7999344dc630 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/4/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> **Functional tests**
> - Quick Start
> - Entity creation via REST APIs.
> - Entity creation via APIs.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 14, 2018, 12:02 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Updates include:
- Addressed review comments.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 9dba1c06fa5548470056cf8cf095f3d2744650b0 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 381191986df81d691e2598d4760d7999344dc630 


Diff: https://reviews.apache.org/r/68312/diff/4/

Changes: https://reviews.apache.org/r/68312/diff/3-4/


Testing
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.

**Functional tests**
- Quick Start
- Entity creation via REST APIs.
- Entity creation via APIs.


File Attachments
----------------

rdbms-db.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
typesDef-soft-ref.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 13, 2018, 9:52 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Updates include: 
- Function testing section.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b6d82dd834b8cc8b3bac630c084b91ac34dd0cec 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
  repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
  repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 


Diff: https://reviews.apache.org/r/68312/diff/3/


Testing (updated)
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.

**Functional tests**
- Quick Start
- Entity creation via REST APIs.
- Entity creation via APIs.


File Attachments
----------------

rdbms-db.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
typesDef-soft-ref.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 13, 2018, 8:52 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Updaetes include: Addressed review comments.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b6d82dd834b8cc8b3bac630c084b91ac34dd0cec 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
  repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
  repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 


Diff: https://reviews.apache.org/r/68312/diff/3/

Changes: https://reviews.apache.org/r/68312/diff/2-3/


Testing
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.


File Attachments
----------------

rdbms-db.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
typesDef-soft-ref.json
  https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Sarath Subramanian <sa...@apache.org>.

> On Aug. 13, 2018, 12:09 p.m., Sarath Subramanian wrote:
> > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java
> > Lines 259 (patched)
> > <https://reviews.apache.org/r/68312/diff/2/?file=2071938#file2071938line259>
> >
> >     "softRef" => "softReference"

or "softRef" => "isSoftReference"


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207159
-----------------------------------------------------------


On Aug. 13, 2018, 10:31 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:31 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
>   repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
>   repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/2/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207159
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java
Lines 259 (patched)
<https://reviews.apache.org/r/68312/#comment290450>

    "softRef" => "softReference"



intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java
Lines 277 (patched)
<https://reviews.apache.org/r/68312/#comment290451>

    include 'options' in hashCode() and equals() methods.



intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java
Lines 419 (patched)
<https://reviews.apache.org/r/68312/#comment290452>

    isSoftRefSet() => isSoftReferenced()



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 349 (patched)
<https://reviews.apache.org/r/68312/#comment290453>

    ctx.getValue() can also be a Map, check and map the value back to  object ID. Could you check if normalized value is mapped back to ObjectID



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 353 (patched)
<https://reviews.apache.org/r/68312/#comment290454>

    consider refactoring like below instead of adding a new method.
    
    ctx.setValue(softRefValue);
    mapPrimitiveValue(ctx);



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 532 (patched)
<https://reviews.apache.org/r/68312/#comment290455>

    constructor of AtlasObjectId(guid, typeName)
    
    I think the Index name is swapped, it should be
    SOFT_REFERENCE_FORMAT_INDEX_TYPE_NAME = 0
    SOFT_INDEX_REFERENCE_GUID = 1
    
    return new AtlasObjectId(
    objectIdParts[SOFT_INDEX_REFERENCE_GUID],             
    objectIdParts[SOFT_REFERENCE_FORMAT_INDEX_TYPE_NAME]);


- Sarath Subramanian


On Aug. 13, 2018, 10:31 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:31 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
>   repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
>   repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/2/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Tests verify object, array<object>, map<string,object> cases.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
> typesDef-soft-ref.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 13, 2018, 5:31 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Updates include:
- Added support for map and array.
- Additional unit tests.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
  repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
  repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 


Diff: https://reviews.apache.org/r/68312/diff/2/

Changes: https://reviews.apache.org/r/68312/diff/1-2/


Testing (updated)
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.


File Attachments
----------------

rdbms-db.json
  https://reviews.apache.org/media/uploaded/files/2018/08/12/1f45deeb-55d7-4c68-8640-ca184cf08a2c__rdbms-db.json
TypesDef with softRef
  https://reviews.apache.org/media/uploaded/files/2018/08/12/e1e7a8c1-13b5-453a-b240-9217a723dd15__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Re: Review Request 68312: AttributeDef Update: Support for Soft Reference

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/#review207139
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Line 329 (original), 333 (patched)
<https://reviews.apache.org/r/68312/#comment290382>

    Shouldn't MAP and ARRAY types be updated to handle soft-references? For example, type=array<EntityType>, type=map<string,EntityType>.



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 345 (patched)
<https://reviews.apache.org/r/68312/#comment290371>

    Shouldn't this be "!(ctx.getValue() instanceof AtlasObjectId)" - missing '!'?


- Madhan Neethiraj


On Aug. 12, 2018, 9:48 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68312/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2018, 9:48 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2813
>     https://issues.apache.org/jira/browse/ATLAS-2813
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Add _options_ field to _AtlasAttributeDef_.
> - Implement support in _AtlasStructDefStore_.
> - Update _EntityGraphMapper_
> - Update _EntityGraphRetriever_
> - Supports array of objects and objects.
> 
> **Usage**
> See attached JSON.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION 
>   repository/src/test/resources/json/rdbms-db.json PRE-CREATION 
>   repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68312/diff/1/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Additional tests.
> 
> 
> File Attachments
> ----------------
> 
> rdbms-db.json
>   https://reviews.apache.org/media/uploaded/files/2018/08/12/1f45deeb-55d7-4c68-8640-ca184cf08a2c__rdbms-db.json
> TypesDef with softRef
>   https://reviews.apache.org/media/uploaded/files/2018/08/12/e1e7a8c1-13b5-453a-b240-9217a723dd15__typesDef-soft-ref.json
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>