You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/08 18:03:46 UTC

[GitHub] [arrow] wjones127 opened a new pull request, #13345: docs: Remove experimental marker from C Streaming Interface

wjones127 opened a new pull request, #13345:
URL: https://github.com/apache/arrow/pull/13345

   DO NOT MERGE: changes pending vote from PMC.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zhztheplayer commented on a diff in pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
zhztheplayer commented on code in PR #13345:
URL: https://github.com/apache/arrow/pull/13345#discussion_r893379746


##########
java/c/src/main/java/org/apache/arrow/c/Data.java:
##########
@@ -36,8 +36,7 @@
 /**
  * Functions for working with the C data interface.
  * <p>
- * This API is EXPERIMENTAL. Note that currently only 64bit systems are
- * supported.

Review Comment:
   Yes afaik we don't yet have any codes about C Stream Interface in Java.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13345:
URL: https://github.com/apache/arrow/pull/13345#issuecomment-1150230450

   https://issues.apache.org/jira/browse/ARROW-16789


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on a diff in pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13345:
URL: https://github.com/apache/arrow/pull/13345#discussion_r897150695


##########
java/c/src/main/java/org/apache/arrow/c/Data.java:
##########
@@ -38,6 +38,7 @@
  * <p>
  * This API is EXPERIMENTAL. Note that currently only 64bit systems are
  * supported.
+ * Note that currently only 64bit systems are supported.

Review Comment:
   This line was duplicated by mistake? :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wjones127 commented on a diff in pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
wjones127 commented on code in PR #13345:
URL: https://github.com/apache/arrow/pull/13345#discussion_r893575296


##########
java/c/src/main/java/org/apache/arrow/c/Data.java:
##########
@@ -36,8 +36,7 @@
 /**
  * Functions for working with the C data interface.
  * <p>
- * This API is EXPERIMENTAL. Note that currently only 64bit systems are
- * supported.

Review Comment:
   Okay sorry I misinterpreted that. I will revert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #13345: docs: Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13345:
URL: https://github.com/apache/arrow/pull/13345#issuecomment-1150229346

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wjones127 commented on pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
wjones127 commented on PR #13345:
URL: https://github.com/apache/arrow/pull/13345#issuecomment-1155207379

   (This also resolves https://issues.apache.org/jira/browse/ARROW-14613)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou merged pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
pitrou merged PR #13345:
URL: https://github.com/apache/arrow/pull/13345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on a diff in pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13345:
URL: https://github.com/apache/arrow/pull/13345#discussion_r893348521


##########
java/c/src/main/java/org/apache/arrow/c/Data.java:
##########
@@ -36,8 +36,7 @@
 /**
  * Functions for working with the C data interface.
  * <p>
- * This API is EXPERIMENTAL. Note that currently only 64bit systems are
- * supported.

Review Comment:
   Do we want to remove this here? The fact that the Java API is experimental is a bit unrelated to the status of the C stream interface.
   cc @zhztheplayer for opinions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on a diff in pull request #13345: ARROW-16789: [Format] Remove experimental marker from C Streaming Interface

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13345:
URL: https://github.com/apache/arrow/pull/13345#discussion_r897151002


##########
java/c/src/main/java/org/apache/arrow/c/Data.java:
##########
@@ -38,6 +38,7 @@
  * <p>
  * This API is EXPERIMENTAL. Note that currently only 64bit systems are
  * supported.
+ * Note that currently only 64bit systems are supported.

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org