You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by YoshikiHigo <gi...@git.apache.org> on 2016/08/19 06:37:22 UTC
[GitHub] ant pull request #20: Microoptimization. Followup to commit 5f20b99140fb4ec9...
GitHub user YoshikiHigo opened a pull request:
https://github.com/apache/ant/pull/20
Microoptimization. Followup to commit 5f20b99140fb4ec958a6d540b9df7b3\u2026
This commit includes a very small optimization, which is a followup to commit 5f20b99140fb4ec958a6d540b9df7b3c08312b40.
Yoshiki, Shinpei, Hideaki, and Mei.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YoshikiHigo/ant opt01
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit 589514f761367e023a23da015cd7715d7c5ac2bc
Author: Yoshiki Higo <yo...@gmail.com>
Date: 2016-08-19T06:17:42Z
microoptimization. Followup to commit 5f20b99140fb4ec958a6d540b9df7b3c08312b40
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #20: Microoptimization. Followup to commit 5f20b99140fb4ec958a6d54...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/20
we all make mistakes, no problem. Sorry if I sounded rude. Your contributions are very much appreciated.
Could you please close this PR? I can't do it myself (easily).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #20: Microoptimization. Followup to commit 5f20b99140fb4ec958a6d54...
Posted by YoshikiHigo <gi...@git.apache.org>.
Github user YoshikiHigo commented on the issue:
https://github.com/apache/ant/pull/20
Thank you.
I'll close this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #20: Microoptimization. Followup to commit 5f20b99140fb4ec958a6d54...
Posted by YoshikiHigo <gi...@git.apache.org>.
Github user YoshikiHigo commented on the issue:
https://github.com/apache/ant/pull/20
I'm very sorry for my careless mistake.
Please ignore this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #20: Microoptimization. Followup to commit 5f20b99140fb4ec9...
Posted by YoshikiHigo <gi...@git.apache.org>.
Github user YoshikiHigo closed the pull request at:
https://github.com/apache/ant/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #20: Microoptimization. Followup to commit 5f20b99140fb4ec958a6d54...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/20
please see the three lines of comment just above the line you've changed, this "micro-optimization" would break builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org