[GitHub] [superset] betodealmeida commented on pull request #18098: feat: command to sync DBT to Superset

[GitBox <gi...@apache.org>]

betodealmeida commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1019296794


   > Beto, are you aware of this project? https://github.com/slidoapp/dbt-superset-lineage I haven't tried it, though...
   
   Yes, it was the inspiration! I should've mentioned it in the summary, I'll update it. I think both approaches are valid — this one here is simpler because you're using the CLI, while the other uses the API and is valuable for cases where you don't have direct access.
   
   > Regarding your approach, I have some doubts on automatically updating the DB connection. In many cases people may want to use a different user here, or different connection strings for the sake of things like user impersonation, proxy settings, roles, warehouse settings (Snowflake), etc. I know that you are currently only covering Postgres, but for other databases it may become troublesome. Maybe this step could be made optional?
   
   That's a great point! I'll make it optional, allowing the user to reuse an existing DB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org