You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/16 12:08:24 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #1318: Expose column index and offset index

alamb commented on a change in pull request #1318:
URL: https://github.com/apache/arrow-rs/pull/1318#discussion_r807873209



##########
File path: parquet/src/file/metadata.rs
##########
@@ -350,6 +350,10 @@ pub struct ColumnChunkMetaData {
     dictionary_page_offset: Option<i64>,
     statistics: Option<Statistics>,
     bloom_filter_offset: Option<i64>,
+    offset_index_offset: Option<i64>,

Review comment:
       `offset_index_offset` and `offset_index_length` are unfortunate names (such `offset`!) 🤪 
   
   However, it seems that is what they are called in the parquet format itself so consistency in the rust implementation is 👍 
   
   https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L798-L802




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org