You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/09/16 19:56:35 UTC
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14236
Change subject: IMPALA-8947: scratch alloc error uses wrong metric
......................................................................
IMPALA-8947: scratch alloc error uses wrong metric
Use the global metric instead of the per-FileGroup
counter.
Testing:
Updated unit test to validate the error message in
a case where there are two FileGroups.
Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
---
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/util/metrics.h
3 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/14236/1
--
To view, visit http://gerrit.cloudera.org:8080/14236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Gerrit-Change-Number: 14236
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 )
Change subject: IMPALA-8947: scratch alloc error uses wrong metric
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Gerrit-Change-Number: 14236
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:26:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 )
Change subject: IMPALA-8947: scratch alloc error uses wrong metric
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Gerrit-Change-Number: 14236
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 )
Change subject: IMPALA-8947: scratch alloc error uses wrong metric
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4566/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Gerrit-Change-Number: 14236
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14236 )
Change subject: IMPALA-8947: scratch alloc error uses wrong metric
......................................................................
IMPALA-8947: scratch alloc error uses wrong metric
Use the global metric instead of the per-FileGroup
counter.
Testing:
Updated unit test to validate the error message in
a case where there are two FileGroups.
Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Reviewed-on: http://gerrit.cloudera.org:8080/14236
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/util/metrics.h
3 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Gerrit-Change-Number: 14236
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 )
Change subject: IMPALA-8947: scratch alloc error uses wrong metric
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Gerrit-Change-Number: 14236
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Sep 2019 00:47:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 )
Change subject: IMPALA-8947: scratch alloc error uses wrong metric
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4954/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81
Gerrit-Change-Number: 14236
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:13 +0000
Gerrit-HasComments: No