You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/03 03:13:18 UTC

[GitHub] [incubator-shardingsphere] yuzel opened a new pull request #4577: #4482 Correct the `DataTypeName` for SQLServer

yuzel opened a new pull request #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577
 
 
   Fixes #4882.
   
   Changes proposed in this pull request:
   - [https://docs.microsoft.com/en-us/sql/t-sql/data-types/data-types-transact-sql?view=sql-server-ver15](default data type)
   - [https://docs.microsoft.com/en-us/sql/t-sql/statements/create-type-transact-sql?view=sql-server-ver15](create data type)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#issuecomment-593751045
 
 
   ## Pull Request Test Coverage Report for [Build 1960](https://coveralls.io/builds/29090183)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.01%**) to **58.405%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29090183/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29090183/badge)](https://coveralls.io/builds/29090183) |
   | :-- | --: |
   | Change from base [Build 9964](https://coveralls.io/builds/29071225): |  0.01% |
   | Covered Lines: | 10524 |
   | Relevant Lines: | 18019 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#issuecomment-593760244
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#issuecomment-593751045
 
 
   ## Pull Request Test Coverage Report for [Build 9970](https://coveralls.io/builds/29089076)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **58.394%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29089076/badge)](https://coveralls.io/builds/29089076) |
   | :-- | --: |
   | Change from base [Build 9964](https://coveralls.io/builds/29071225): |  0.0% |
   | Covered Lines: | 10522 |
   | Relevant Lines: | 18019 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#issuecomment-593876049
 
 
   Hi @yuzel You can use `Ref #4482`  to link this PR to that issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#discussion_r386811520
 
 

 ##########
 File path: sharding-sql-test/src/main/resources/sql/supported/ddl/alter.xml
 ##########
 @@ -25,16 +25,17 @@
     <sql-case id="alter_table_with_back_quota" value="ALTER TABLE `t_order` FORCE" db-types="MySQL" />
     <sql-case id="alter_table_add_column" value="ALTER TABLE t_order ADD column4 VARCHAR(10)" />
     <sql-case id="alter_table_add_columns" value="ALTER TABLE t_order ADD column4 VARCHAR(10), ADD column5 VARCHAR(10), ADD column6 VARCHAR(10)" db-types="MySQL,PostgreSQL" />
-    <sql-case id="alter_table_add_columns_integer_type_mysql" value="ALTER TABLE t_order ADD column4 TINYINT, ADD column5 MEDIUMINT" db-types="MySQL" />
+    <sql-case id="alter_table_add_columns_integer_type_mysql" value="ALTER TABLE t_order ADD column4 INTEGER, ADD column5 TINYINT, ADD column6 MEDIUMINT" db-types="MySQL" />
 
 Review comment:
   If the scope of this pr is for data type of SQLServer only, why do change test case for MySQL?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#discussion_r386810954
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/SQLServerKeyword.g4
 ##########
 @@ -854,3 +854,63 @@ FIRST
 ONLY
     : O N L Y
     ;
+
+MONEY
+    : M O N E Y
+    ;
+
+SMALLMONEY
+    : S M A L L M O N E Y
+    ;
+
+DATETIMEOFFSET
+    : D A T E T I M E O F F S E T
+    ;
+
+DATETIME
+    : D A T E T I M E [2]?
+    ;
+
+SMALLDATETIME
+    : S M A L L D A T E T I M E
+    ;
+
+NCHAR
+    : N C H A R
+    ;
+
+NVARCHAR
+    : N V A R C H A R
+    ;
+
+NTEXT
+    : N T E X T
+    ;
+
+VARBINARY
+    : V A R B I N A R Y
+    ;
+
+IMAGE
+    : I M A G E
+    ;
+
+SQL_VARIANT
+    : S Q L UL_ V A R I A N T
+    ;
+
+UNIQUEIDENTIFIER
+    : U N I Q U E I D E N T I F I E R
+    ;
+
+HIERARCHYID
+    : H I E R A R C H Y I D
+    ;
+
+GEOMETRY
+    : G E O M E T R Y
+    ;
+
+GEOGRAPHY
+    : G E O G R A P H Y
+    ;
 
 Review comment:
   Please add a empty line at end of file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#discussion_r386810930
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/Keyword.g4
 ##########
 @@ -535,3 +535,39 @@ DECIMAL
 TYPE
     : T Y P E
     ;
+
+BIT
+    : B I T
+    ;
+
+SMALLINT
+    : S M A L L I N T
+    ;
+
+INT
+    : I N T
+    ;
+
+TINYINT
+    : T I N Y I N T
+    ;
+
+NUMERIC
+    : N U M E R I C
+    ;
+
+FLOAT
+    : F L O A T
+    ;
+
+BIGINT
+    : B I G I N T
+    ;
+
+TEXT
+    : T E X T
+    ;
+
+VARCHAR
+    : V A R C H A R
+    ;
 
 Review comment:
   Please add a empty line at end of file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yuzel commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
yuzel commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#discussion_r386882393
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/SQLServerKeyword.g4
 ##########
 @@ -854,3 +854,63 @@ FIRST
 ONLY
     : O N L Y
     ;
+
+MONEY
+    : M O N E Y
+    ;
+
+SMALLMONEY
+    : S M A L L M O N E Y
+    ;
+
+DATETIMEOFFSET
+    : D A T E T I M E O F F S E T
+    ;
+
+DATETIME
+    : D A T E T I M E [2]?
+    ;
+
+SMALLDATETIME
+    : S M A L L D A T E T I M E
+    ;
+
+NCHAR
+    : N C H A R
+    ;
+
+NVARCHAR
+    : N V A R C H A R
+    ;
+
+NTEXT
+    : N T E X T
+    ;
+
+VARBINARY
+    : V A R B I N A R Y
+    ;
+
+IMAGE
+    : I M A G E
+    ;
+
+SQL_VARIANT
+    : S Q L UL_ V A R I A N T
+    ;
+
+UNIQUEIDENTIFIER
+    : U N I Q U E I D E N T I F I E R
+    ;
+
+HIERARCHYID
+    : H I E R A R C H Y I D
+    ;
+
+GEOMETRY
+    : G E O M E T R Y
+    ;
+
+GEOGRAPHY
+    : G E O G R A P H Y
+    ;
 
 Review comment:
   I added a blank line, but the file change is not displayed, but the code after the local submission shows that there is a blank line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#issuecomment-593751045
 
 
   ## Pull Request Test Coverage Report for [Build 9977](https://coveralls.io/builds/29094074)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **58.394%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29094074/badge)](https://coveralls.io/builds/29094074) |
   | :-- | --: |
   | Change from base [Build 9964](https://coveralls.io/builds/29071225): |  0.0% |
   | Covered Lines: | 10522 |
   | Relevant Lines: | 18019 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yuzel commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer

Posted by GitBox <gi...@apache.org>.
yuzel commented on a change in pull request #4577: #4482 Correct the `DataTypeName` for SQLServer
URL: https://github.com/apache/incubator-shardingsphere/pull/4577#discussion_r386824349
 
 

 ##########
 File path: sharding-sql-test/src/main/resources/sql/supported/ddl/alter.xml
 ##########
 @@ -25,16 +25,17 @@
     <sql-case id="alter_table_with_back_quota" value="ALTER TABLE `t_order` FORCE" db-types="MySQL" />
     <sql-case id="alter_table_add_column" value="ALTER TABLE t_order ADD column4 VARCHAR(10)" />
     <sql-case id="alter_table_add_columns" value="ALTER TABLE t_order ADD column4 VARCHAR(10), ADD column5 VARCHAR(10), ADD column6 VARCHAR(10)" db-types="MySQL,PostgreSQL" />
-    <sql-case id="alter_table_add_columns_integer_type_mysql" value="ALTER TABLE t_order ADD column4 TINYINT, ADD column5 MEDIUMINT" db-types="MySQL" />
+    <sql-case id="alter_table_add_columns_integer_type_mysql" value="ALTER TABLE t_order ADD column4 INTEGER, ADD column5 TINYINT, ADD column6 MEDIUMINT" db-types="MySQL" />
 
 Review comment:
   Because I changed the test case `alter_table_add_columns_integer_type` to support `MySQL, PostgreSQL, SQLServer`, but SQLServer does not support Integer, so I modified  `MySQL`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services