You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org> on 2019/07/07 10:53:00 UTC
[jira] [Commented] (KARAF-6353) Sanitize ShutdownSocketThread
command log
[ https://issues.apache.org/jira/browse/KARAF-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879828#comment-16879828 ]
Jean-Baptiste Onofré commented on KARAF-6353:
---------------------------------------------
Good point, let me improve this.
> Sanitize ShutdownSocketThread command log
> -----------------------------------------
>
> Key: KARAF-6353
> URL: https://issues.apache.org/jira/browse/KARAF-6353
> Project: Karaf
> Issue Type: Improvement
> Components: karaf
> Reporter: Colm O hEigeartaigh
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 4.3.0, 4.2.7
>
>
> In ShutdownSocketThread it logs an unsucessful command with:
> {code}
> LOG.log(Level.WARNING, "Karaf shutdown socket: Invalid command '" +
> command.toString() + "' received");
> {code}
> Here we should make sure to sanitize the command.toString() output, as otherwise it gives an attacker the opportunity to pollute the logs with CRLF characters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)