You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/30 03:13:28 UTC
[GitHub] [flink] edu05 opened a new pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
edu05 opened a new pull request #11952:
URL: https://github.com/apache/flink/pull/11952
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Fix a bug where an exception was being thrown when a savepoint couldn't be mapped to an ExecutionJobVertex due to the user having specified the operator hash manually
## Brief change log
- Refactored code to make it more explicit that a JobVertex has an operator id and possibly an user defined operator id, this should prevent future similar bugs where this wasn't obvious
- Fixed the bug
- Some code that was only being used in tests got deleted
## Verifying this change
- A new unit test was added
- Ideally the creator of the JIRA ticket would verify if the PR fixes their issue
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? (yes / *no*)
- If yes, how is the feature documented? (*not applicable* / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-624330629
> Thanks for updating, @edu05.
> The changes look good to me.
Awesome, who can merge the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-623938413
@rkhachatryan done, all systems running!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11952:
URL: https://github.com/apache/flink/pull/11952#discussion_r418193478
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -371,7 +371,7 @@ public TaskAcknowledgeResult acknowledgeTask(
acknowledgedTasks.add(executionAttemptId);
}
- List<OperatorID> operatorIDs = vertex.getJobVertex().getOperatorIDs();
+ List<OperatorID> operatorIDs = vertex.getJobVertex().getOperatorIdPairList().getOperatorIds();
Review comment:
`vertex.getOperatorIdPairList().getOperatorIds` sounds a bit repetitive to me.
How about `vertex.getOperatorIDs().getGeneratedIDs()`?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
##########
@@ -289,21 +270,12 @@ public ExecutionJobVertex(
}
/**
- * Returns a list containing the IDs of all operators contained in this execution job vertex.
+ * Returns a list containing the ID pairs of all operators contained in this execution job vertex.
*
- * @return list containing the IDs of all contained operators
+ * @return list containing the ID pairs of all contained operators
*/
- public List<OperatorID> getOperatorIDs() {
- return operatorIDs;
- }
-
- /**
- * Returns a list containing the alternative IDs of all operators contained in this execution job vertex.
- *
- * @return list containing alternative the IDs of all contained operators
- */
- public List<OperatorID> getUserDefinedOperatorIDs() {
- return userDefinedOperatorIds;
+ public OperatorIdPairList getOperatorIdPairList() {
Review comment:
Isn't name `getOperatorIdPairs` enough (instead of `getOperatorIdPairList`)?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java
##########
@@ -143,27 +145,27 @@ public JobVertex(String name) {
public JobVertex(String name, JobVertexID id) {
this.name = name == null ? DEFAULT_NAME : name;
this.id = id == null ? new JobVertexID() : id;
- // the id lists must have the same size
- this.operatorIDs.add(OperatorID.fromJobVertexID(this.id));
- this.operatorIdsAlternatives.add(null);
+ OperatorIdPair operatorIdPair = new OperatorIdPair(OperatorID.fromJobVertexID(this.id), null);
+ this.operatorIdPairList = new OperatorIdPairList(Collections.singletonList(operatorIdPair));
}
/**
* Constructs a new job vertex and assigns it with the given name.
*
* @param name The name of the new job vertex.
* @param primaryId The id of the job vertex.
- * @param alternativeIds The alternative ids of the job vertex.
* @param operatorIds The ids of all operators contained in this job vertex.
* @param alternativeOperatorIds The alternative ids of all operators contained in this job vertex-
*/
- public JobVertex(String name, JobVertexID primaryId, List<JobVertexID> alternativeIds, List<OperatorID> operatorIds, List<OperatorID> alternativeOperatorIds) {
+ public JobVertex(String name, JobVertexID primaryId, List<OperatorID> operatorIds, List<OperatorID> alternativeOperatorIds) {
Preconditions.checkArgument(operatorIds.size() == alternativeOperatorIds.size());
this.name = name == null ? DEFAULT_NAME : name;
this.id = primaryId == null ? new JobVertexID() : primaryId;
- this.idAlternatives.addAll(alternativeIds);
- this.operatorIDs.addAll(operatorIds);
- this.operatorIdsAlternatives.addAll(alternativeOperatorIds);
+ List<OperatorIdPair> operatorIdPairs = new ArrayList<>();
+ for (int i = 0; i < operatorIds.size(); i++) {
+ operatorIdPairs.add(new OperatorIdPair(operatorIds.get(i), alternativeOperatorIds.get(i)));
+ }
+ this.operatorIdPairList = new OperatorIdPairList(operatorIdPairs);
Review comment:
Ideally, this should be done by the caller (i.e. `StreamingJobGraphGenerator.createJobVertex`) so the constructor receives a list of pairs.
Also, lists here don't guarantee constant time `get(int)` and it's good to check that both lists have the same size.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/OperatorIdPairList.java
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.jobgraph;
+
+import org.apache.flink.runtime.OperatorIdPair;
+
+import java.io.Serializable;
+import java.util.AbstractList;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Convenience class to encapsulate the operator ID pairs of a job vertex. It is convenient because it hides
+ * away the creation of a new list for only operator IDs or user defined operator IDs.
+ * It also hides the iteration over operator ID pairs.
+ */
+public class OperatorIdPairList extends AbstractList<OperatorIdPair> implements Serializable {
Review comment:
I'm not sure if we need this class:
- `getUserDefinedOperatorIds` is never used
- constructor can be inlined
- instead of `getOperatorIds()` clients could iterate over pairs with minimal changes, e.g. in `StateAssignmentOperation`:
```
List<OperatorIdPair> pairs = executionJobVertex.getOperatorIdPairList().getOperatorIds();
int expectedNumberOfSubTasks = newParallelism * pairs.size();
for (OperatorIdPair pair : operatorIDs) {
OperatorInstanceID instanceID = OperatorInstanceID.of(subTaskIndex, pair.getOperatorId());
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTestingUtils.java
##########
@@ -357,8 +359,11 @@ static ExecutionJobVertex mockExecutionJobVertex(
when(executionJobVertex.getParallelism()).thenReturn(parallelism);
when(executionJobVertex.getMaxParallelism()).thenReturn(maxParallelism);
when(executionJobVertex.isMaxParallelismConfigured()).thenReturn(true);
- when(executionJobVertex.getOperatorIDs()).thenReturn(jobVertexIDs);
- when(executionJobVertex.getUserDefinedOperatorIDs()).thenReturn(Arrays.asList(new OperatorID[jobVertexIDs.size()]));
+ List<OperatorIdPair> operatorIdPairs = new ArrayList<>();
+ for (OperatorID operatorID : jobVertexIDs) {
+ operatorIdPairs.add(new OperatorIdPair(operatorID, null));
Review comment:
What do you think about a factory method to create `OperatorIdPair` from only generated ID?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3533a49c3d105fe2aca954bdb48223fe4b31f634 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506)
* 32c31c798a471aa1f5035f39b7aef2a107bbc27b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-624506548
@pnowojski can you please take a look and merge if it LGTY?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622291868
Thanks @edu05 ,
Yes, I think title should be omitted (especially given that the changes have now broader scope than the original issue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
}, {
"hash" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523",
"triggerID" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"triggerType" : "PUSH"
}, {
"hash" : "5a2f6e8bd534d439b30e10b41a17821a3ea93590",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=586",
"triggerID" : "5a2f6e8bd534d439b30e10b41a17821a3ea93590",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2113227fdc0076eb9e2f72ae7883c2d5d245cbab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523)
* 5a2f6e8bd534d439b30e10b41a17821a3ea93590 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=586)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
}, {
"hash" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb00ba58dee155aceb27bd4b8bab837a77265699 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514)
* 2113227fdc0076eb9e2f72ae7883c2d5d245cbab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3533a49c3d105fe2aca954bdb48223fe4b31f634 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506)
* 32c31c798a471aa1f5035f39b7aef2a107bbc27b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
}, {
"hash" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523",
"triggerID" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb00ba58dee155aceb27bd4b8bab837a77265699 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514)
* 2113227fdc0076eb9e2f72ae7883c2d5d245cbab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622328404
@rkhachatryan done :) let's hope for a green Azure build now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11952:
URL: https://github.com/apache/flink/pull/11952#discussion_r418454035
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTestingUtils.java
##########
@@ -357,8 +359,11 @@ static ExecutionJobVertex mockExecutionJobVertex(
when(executionJobVertex.getParallelism()).thenReturn(parallelism);
when(executionJobVertex.getMaxParallelism()).thenReturn(maxParallelism);
when(executionJobVertex.isMaxParallelismConfigured()).thenReturn(true);
- when(executionJobVertex.getOperatorIDs()).thenReturn(jobVertexIDs);
- when(executionJobVertex.getUserDefinedOperatorIDs()).thenReturn(Arrays.asList(new OperatorID[jobVertexIDs.size()]));
+ List<OperatorIdPair> operatorIdPairs = new ArrayList<>();
+ for (OperatorID operatorID : jobVertexIDs) {
+ operatorIdPairs.add(new OperatorIdPair(operatorID, null));
Review comment:
I'd prefer more descriptive name for one-argument version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-623554001
@rkhachatryan Are there any outstanding issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2f1b05a35fa8d43aa04cafbecc0333680b09a37 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621587868
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e2f1b05a35fa8d43aa04cafbecc0333680b09a37 (Thu Apr 30 03:16:13 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on a change in pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on a change in pull request #11952:
URL: https://github.com/apache/flink/pull/11952#discussion_r418310356
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTestingUtils.java
##########
@@ -357,8 +359,11 @@ static ExecutionJobVertex mockExecutionJobVertex(
when(executionJobVertex.getParallelism()).thenReturn(parallelism);
when(executionJobVertex.getMaxParallelism()).thenReturn(maxParallelism);
when(executionJobVertex.isMaxParallelismConfigured()).thenReturn(true);
- when(executionJobVertex.getOperatorIDs()).thenReturn(jobVertexIDs);
- when(executionJobVertex.getUserDefinedOperatorIDs()).thenReturn(Arrays.asList(new OperatorID[jobVertexIDs.size()]));
+ List<OperatorIdPair> operatorIdPairs = new ArrayList<>();
+ for (OperatorID operatorID : jobVertexIDs) {
+ operatorIdPairs.add(new OperatorIdPair(operatorID, null));
Review comment:
done, is it a terrible idea that both factory methods have the same name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622489226
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-623702887
@edu05 can you please squash the commits and rebase to the latest master (Azure build still fails)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2f1b05a35fa8d43aa04cafbecc0333680b09a37 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32c31c798a471aa1f5035f39b7aef2a107bbc27b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509)
* cb00ba58dee155aceb27bd4b8bab837a77265699 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2f1b05a35fa8d43aa04cafbecc0333680b09a37 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446)
* 846b989b173e24ab549e8aba342f0609afe2c25a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32c31c798a471aa1f5035f39b7aef2a107bbc27b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 846b989b173e24ab549e8aba342f0609afe2c25a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461)
* 3533a49c3d105fe2aca954bdb48223fe4b31f634 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622941641
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3533a49c3d105fe2aca954bdb48223fe4b31f634 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 846b989b173e24ab549e8aba342f0609afe2c25a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on a change in pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on a change in pull request #11952:
URL: https://github.com/apache/flink/pull/11952#discussion_r418310611
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
##########
@@ -289,21 +270,12 @@ public ExecutionJobVertex(
}
/**
- * Returns a list containing the IDs of all operators contained in this execution job vertex.
+ * Returns a list containing the ID pairs of all operators contained in this execution job vertex.
*
- * @return list containing the IDs of all contained operators
+ * @return list containing the ID pairs of all contained operators
*/
- public List<OperatorID> getOperatorIDs() {
- return operatorIDs;
- }
-
- /**
- * Returns a list containing the alternative IDs of all operators contained in this execution job vertex.
- *
- * @return list containing alternative the IDs of all contained operators
- */
- public List<OperatorID> getUserDefinedOperatorIDs() {
- return userDefinedOperatorIds;
+ public OperatorIdPairList getOperatorIdPairList() {
Review comment:
done by removing the class altogether
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -371,7 +371,7 @@ public TaskAcknowledgeResult acknowledgeTask(
acknowledgedTasks.add(executionAttemptId);
}
- List<OperatorID> operatorIDs = vertex.getJobVertex().getOperatorIDs();
+ List<OperatorID> operatorIDs = vertex.getJobVertex().getOperatorIdPairList().getOperatorIds();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622193610
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621659176
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
}, {
"hash" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523",
"triggerID" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2113227fdc0076eb9e2f72ae7883c2d5d245cbab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb00ba58dee155aceb27bd4b8bab837a77265699 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2f1b05a35fa8d43aa04cafbecc0333680b09a37 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446)
* 846b989b173e24ab549e8aba342f0609afe2c25a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
}, {
"hash" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523",
"triggerID" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"triggerType" : "PUSH"
}, {
"hash" : "5a2f6e8bd534d439b30e10b41a17821a3ea93590",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a2f6e8bd534d439b30e10b41a17821a3ea93590",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2113227fdc0076eb9e2f72ae7883c2d5d245cbab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523)
* 5a2f6e8bd534d439b30e10b41a17821a3ea93590 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on a change in pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on a change in pull request #11952:
URL: https://github.com/apache/flink/pull/11952#discussion_r418310429
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/OperatorIdPairList.java
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.jobgraph;
+
+import org.apache.flink.runtime.OperatorIdPair;
+
+import java.io.Serializable;
+import java.util.AbstractList;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Convenience class to encapsulate the operator ID pairs of a job vertex. It is convenient because it hides
+ * away the creation of a new list for only operator IDs or user defined operator IDs.
+ * It also hides the iteration over operator ID pairs.
+ */
+public class OperatorIdPairList extends AbstractList<OperatorIdPair> implements Serializable {
Review comment:
done
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java
##########
@@ -143,27 +145,27 @@ public JobVertex(String name) {
public JobVertex(String name, JobVertexID id) {
this.name = name == null ? DEFAULT_NAME : name;
this.id = id == null ? new JobVertexID() : id;
- // the id lists must have the same size
- this.operatorIDs.add(OperatorID.fromJobVertexID(this.id));
- this.operatorIdsAlternatives.add(null);
+ OperatorIdPair operatorIdPair = new OperatorIdPair(OperatorID.fromJobVertexID(this.id), null);
+ this.operatorIdPairList = new OperatorIdPairList(Collections.singletonList(operatorIdPair));
}
/**
* Constructs a new job vertex and assigns it with the given name.
*
* @param name The name of the new job vertex.
* @param primaryId The id of the job vertex.
- * @param alternativeIds The alternative ids of the job vertex.
* @param operatorIds The ids of all operators contained in this job vertex.
* @param alternativeOperatorIds The alternative ids of all operators contained in this job vertex-
*/
- public JobVertex(String name, JobVertexID primaryId, List<JobVertexID> alternativeIds, List<OperatorID> operatorIds, List<OperatorID> alternativeOperatorIds) {
+ public JobVertex(String name, JobVertexID primaryId, List<OperatorID> operatorIds, List<OperatorID> alternativeOperatorIds) {
Preconditions.checkArgument(operatorIds.size() == alternativeOperatorIds.size());
this.name = name == null ? DEFAULT_NAME : name;
this.id = primaryId == null ? new JobVertexID() : primaryId;
- this.idAlternatives.addAll(alternativeIds);
- this.operatorIDs.addAll(operatorIds);
- this.operatorIdsAlternatives.addAll(alternativeOperatorIds);
+ List<OperatorIdPair> operatorIdPairs = new ArrayList<>();
+ for (int i = 0; i < operatorIds.size(); i++) {
+ operatorIdPairs.add(new OperatorIdPair(operatorIds.get(i), alternativeOperatorIds.get(i)));
+ }
+ this.operatorIdPairList = new OperatorIdPairList(operatorIdPairs);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622328733
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2f1b05a35fa8d43aa04cafbecc0333680b09a37 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622136550
@rkhachatryan thanks for the comments, I think I've addressed all of them. Regarding the commit comments, they all start with the id of the story plus its title but they do all have an extra comment describing what's been done in them. Would you like me to remove the story title from the commit message so only the id and the latter description is displayed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
}, {
"hash" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=523",
"triggerID" : "2113227fdc0076eb9e2f72ae7883c2d5d245cbab",
"triggerType" : "PUSH"
}, {
"hash" : "5a2f6e8bd534d439b30e10b41a17821a3ea93590",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=586",
"triggerID" : "5a2f6e8bd534d439b30e10b41a17821a3ea93590",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a2f6e8bd534d439b30e10b41a17821a3ea93590 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=586)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-621589853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=446",
"triggerID" : "e2f1b05a35fa8d43aa04cafbecc0333680b09a37",
"triggerType" : "PUSH"
}, {
"hash" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=461",
"triggerID" : "846b989b173e24ab549e8aba342f0609afe2c25a",
"triggerType" : "PUSH"
}, {
"hash" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=506",
"triggerID" : "3533a49c3d105fe2aca954bdb48223fe4b31f634",
"triggerType" : "PUSH"
}, {
"hash" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509",
"triggerID" : "32c31c798a471aa1f5035f39b7aef2a107bbc27b",
"triggerType" : "PUSH"
}, {
"hash" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514",
"triggerID" : "cb00ba58dee155aceb27bd4b8bab837a77265699",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32c31c798a471aa1f5035f39b7aef2a107bbc27b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=509)
* cb00ba58dee155aceb27bd4b8bab837a77265699 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=514)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] edu05 commented on pull request #11952: [FLINK-16638][runtime][checkpointing] Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs
Posted by GitBox <gi...@apache.org>.
edu05 commented on pull request #11952:
URL: https://github.com/apache/flink/pull/11952#issuecomment-622582457
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org