You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "John Hjelmstad (JIRA)" <ji...@apache.org> on 2007/12/17 03:50:42 UTC

[jira] Created: (SHINDIG-1) Use java.net.URI rather than java.net.URL

Use java.net.URI rather than java.net.URL
-----------------------------------------

                 Key: SHINDIG-1
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1
             Project: Shindig
          Issue Type: Improvement
            Reporter: John Hjelmstad
            Priority: Minor


Recommendation by lryan@google.com:
---
I noticed that the Shindig code is using java.net.URL which has some well
known performance issues in its 'equals' method. I think Shindig can happily
use java.net.URI instead and avoid those performance pitfalls and shield
consumers.
---
Seems reasonable to me; no dissent from shindig-dev@. Onward!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1) Use java.net.URI rather than java.net.URL

Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552314 ] 

John Hjelmstad commented on SHINDIG-1:
--------------------------------------

I have a CL that completes nearly all of this conversion (all except RemoteContentFetcher for the moment). ETA early this week.

> Use java.net.URI rather than java.net.URL
> -----------------------------------------
>
>                 Key: SHINDIG-1
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1
>             Project: Shindig
>          Issue Type: Improvement
>            Reporter: John Hjelmstad
>            Priority: Minor
>
> Recommendation by lryan@google.com:
> ---
> I noticed that the Shindig code is using java.net.URL which has some well
> known performance issues in its 'equals' method. I think Shindig can happily
> use java.net.URI instead and avoid those performance pitfalls and shield
> consumers.
> ---
> Seems reasonable to me; no dissent from shindig-dev@. Onward!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1) Use java.net.URI rather than java.net.URL

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1.
--------------------------------

    Resolution: Fixed

I did a scan through the source and didn't see any cases where URL objects were used in collections or where .equals calls are made.  Marking resolved.


> Use java.net.URI rather than java.net.URL
> -----------------------------------------
>
>                 Key: SHINDIG-1
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1
>             Project: Shindig
>          Issue Type: Improvement
>            Reporter: John Hjelmstad
>            Priority: Minor
>
> Recommendation by lryan@google.com:
> ---
> I noticed that the Shindig code is using java.net.URL which has some well
> known performance issues in its 'equals' method. I think Shindig can happily
> use java.net.URI instead and avoid those performance pitfalls and shield
> consumers.
> ---
> Seems reasonable to me; no dissent from shindig-dev@. Onward!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1) Use java.net.URI rather than java.net.URL

Posted by "Vincent Siveton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556718#action_12556718 ] 

Vincent Siveton commented on SHINDIG-1:
---------------------------------------

Already fixed with r608302

> Use java.net.URI rather than java.net.URL
> -----------------------------------------
>
>                 Key: SHINDIG-1
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1
>             Project: Shindig
>          Issue Type: Improvement
>            Reporter: John Hjelmstad
>            Priority: Minor
>
> Recommendation by lryan@google.com:
> ---
> I noticed that the Shindig code is using java.net.URL which has some well
> known performance issues in its 'equals' method. I think Shindig can happily
> use java.net.URI instead and avoid those performance pitfalls and shield
> consumers.
> ---
> Seems reasonable to me; no dissent from shindig-dev@. Onward!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.