You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David Van Couvering (JIRA)" <de...@db.apache.org> on 2006/02/04 02:00:04 UTC
[jira] Created: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
new JDBC4 metadata API getFunctions() needs to be implemented
-------------------------------------------------------------
Key: DERBY-924
URL: http://issues.apache.org/jira/browse/DERBY-924
Project: Derby
Type: New Feature
Environment: JDK 1.6
Reporter: David Van Couvering
For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "A B (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12368116 ]
A B commented on DERBY-924:
---------------------------
> That is probably true, but ODBC 2.0 SQLProcedures specifies, that this column should be VARCHAR(254).
Can you give a link reference that says this? I don't deny it, I'm just curious where this is. When I look here:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbc/htm/odbcsqlprocedurecolumns.asp
I see the type of REMARKS as "VARCHAR" with no length specification. It's possible that "254" is hidden somewhere in there, but if you can give a direct reference that'd be nice :) My work with ODBC metadata in the past (esp. DERBY-107) has suggested that while type is important (ex. CHAR vs VARCHAR, INT vs SMALLINT, nullable vs. not nullable, etc), the specific length of the VARCHAR hasn't been a concern. But of course that's just based on observation from the tests/scenarios I was working with. If length _is_ specified as part of the ODBC specification, then perhaps that's something that needs further investigation (as part of a different Jira issue).
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
David Van Couvering updated DERBY-924:
--------------------------------------
Component: JDBC
Version: 10.2.0.0
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll updated DERBY-924:
---------------------------------
Attachment: derby-924.v1.diff
derby-924.v1.stat
derbyall_report.v1.txt
Patch (derby-924.v1.*). Ran derbyall (1.5) verify that there are no regressions. Also ran the jdbc4 suite without failures (except the report-problem caused by a Mustang bug). Please review. Thanks.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll resolved DERBY-924:
----------------------------------
Resolution: Fixed
Thanks for committing Knut-Anders.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derby-924.v3.diff, derby-924.v3.report.txt, derby-924.v3.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll updated DERBY-924:
---------------------------------
Derby Info: (was: [Patch Available])
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derby-924.v3.diff, derby-924.v3.report.txt, derby-924.v3.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll updated DERBY-924:
---------------------------------
Derby Info: [Patch Available]
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Rick Hillegas closed DERBY-924:
-------------------------------
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derby-924.v3.diff, derby-924.v3.report.txt, derby-924.v3.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "A B (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12368118 ]
A B commented on DERBY-924:
---------------------------
Oops, wrong link in previous comment.
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbc/htm/odbcsqlprocedures.asp
Same kind of thing, though--VARCHAR has no length specified...
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions() needs to be implemented
Posted by Deepa Remesh <dr...@gmail.com>.
> If you update the metadata test and canons as suggested, I'll commit
> the patch with the check commented out.
I just wanted to remind that when updating metadata canons, we also
need to see that the canon for upgrade test (Upgrade_10_1_10_2.out)
gets updated accordingly. Please see DERBY-514 for details on upgrade
test.
I have not been following this issue closely. So please ignore this
comment in case you are already planning to do this.
Thanks,
Deepa
Re: [jira] Commented: (DERBY-924) new JDBC4 metadata API
getFunctions() needs to be implemented
Posted by Knut Anders Hatlen <Kn...@Sun.COM>.
Dyre.Tjeldvoll@Sun.COM writes:
> "Knut Anders Hatlen (JIRA)" <de...@db.apache.org> writes:
>
>> [ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12373839 ]
>>
>> Knut Anders Hatlen commented on DERBY-924:
>> ------------------------------------------
>>
>> The patch looks very good. There are however two issues that I would
>> like to have resolved before I commit the patch.
>>
>> 1) In DatabaseMetaData.getFunctionsX() you have this comment:
>>
>> // Uncomment the following line when DERBY-970 is committed
>> // checkServerJdbcVersionX()
>>
>> Since your patch is likely to get into trunk before my DERBY-970
>> patch, please copy checkServerJdbcVersionX() into your patch and
>> enable the check.
>
> Well, I tried applying that part of your 970 patch to my sandbox, but
> since clientmessages_en.properties has been removed and the messages
> in it given new messageIds, it was impossible :(
Oh, I'm sorry! I had forgotten that the 970 patch was outdated. When I
wrote the comment I thought that it was just a simple copy and paste
job. Now that it turns out that it's not that simple, feel free to
ignore my comment! :)
If you update the metadata test and canons as suggested, I'll commit
the patch with the check commented out. I'll try to update my 970
patch and enable the check when I have resolved the i18n conflict.
> When you coded your patch, SQLState.java looked as follows:
>
> String NOT_IMPLEMENTED = "0A000.S";
> String JDBC_METHOD_NOT_IMPLEMENTED = "0AX01.S";
> + String JDBC_METHOD_NOT_SUPPORTED_BY_SERVER = "0AX02.S";
>
> Since then NOT_IMPLEMENTED and JDBC_METHOD_NOT_IMPLEMENTED has both
> gotten new ids (with the same 5 char prefix):
>
> String NOT_IMPLEMENTED = "0A000.S"; String JDBC_METHOD_NOT_IMPLEMENTED = "0A000.S.1");
>
> So clearly your proposed id doesn't quite fit in. Do you have another
> suggestion? "0A000.S.2" maybe?
Yes, I think 0A000.S.2 should be fine. Thanks for the research!
--
Knut Anders
Re: [jira] Commented: (DERBY-924) new JDBC4 metadata API
getFunctions() needs to be implemented
Posted by Dy...@Sun.COM.
"Knut Anders Hatlen (JIRA)" <de...@db.apache.org> writes:
> [ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12373839 ]
>
> Knut Anders Hatlen commented on DERBY-924:
> ------------------------------------------
>
> The patch looks very good. There are however two issues that I would
> like to have resolved before I commit the patch.
>
> 1) In DatabaseMetaData.getFunctionsX() you have this comment:
>
> // Uncomment the following line when DERBY-970 is committed
> // checkServerJdbcVersionX()
>
> Since your patch is likely to get into trunk before my DERBY-970
> patch, please copy checkServerJdbcVersionX() into your patch and
> enable the check.
Well, I tried applying that part of your 970 patch to my sandbox, but
since clientmessages_en.properties has been removed and the messages
in it given new messageIds, it was impossible :(
When you coded your patch, SQLState.java looked as follows:
String NOT_IMPLEMENTED = "0A000.S";
String JDBC_METHOD_NOT_IMPLEMENTED = "0AX01.S";
+ String JDBC_METHOD_NOT_SUPPORTED_BY_SERVER = "0AX02.S";
Since then NOT_IMPLEMENTED and JDBC_METHOD_NOT_IMPLEMENTED has both
gotten new ids (with the same 5 char prefix):
String NOT_IMPLEMENTED = "0A000.S"; String JDBC_METHOD_NOT_IMPLEMENTED = "0A000.S.1");
So clearly your proposed id doesn't quite fit in. Do you have another
suggestion? "0A000.S.2" maybe?
--
dt
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12373839 ]
Knut Anders Hatlen commented on DERBY-924:
------------------------------------------
The patch looks very good. There are however two issues that I would
like to have resolved before I commit the patch.
1) In DatabaseMetaData.getFunctionsX() you have this comment:
// Uncomment the following line when DERBY-970 is committed
// checkServerJdbcVersionX()
Since your patch is likely to get into trunk before my DERBY-970
patch, please copy checkServerJdbcVersionX() into your patch and
enable the check.
2) I liked the way you managed to test JDBC 4.0 functionality in a
test that doesn't require jdk 1.6 to compile and run, but I don't
see any good reason why the methods are invoked only when
jvm>=1.6. That is, I would have removed these lines from
metadata_test.java:
// Make sure the method is available in the interface
Class.forName("java.sql.DatabaseMetaData").
getMethod("getFunctions", a);
With this change, getFunctions() will be tested in JVM 1.4/1.5 as
well, and you don't need to add separate canons for 1.6. Also note
that this change will require you to update
Upgrade_10_1_10_2.out. (Actually, in your current patch you should
have created a jdk16 version of Upgrade_10_1_10_2.out, but that
won't be necessary now.) I ran the upgrade test (jvm 1.5 and 1.6)
with this change, and the diff looked reasonable.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll updated DERBY-924:
---------------------------------
Other Info: [Patch available]
I'm checking the 'Patch available' box to signal that a new, as of yet unreviewed, patch has been uploaded to this issue. If that is not the intended use of this feature, please let me know, (there seems to be some discussion about this).
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll reopened DERBY-924:
----------------------------------
I'm reopening this issue since the client and NS part was missing from the first patch. (The TestDbMetaData test appeared to run successfully with all frameworks, but it actually ignored the framework and always ran in embedded mode. This has been fixed now).
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12367857 ]
Dyre Tjeldvoll commented on DERBY-924:
--------------------------------------
I think this could be done in much the same way as for getProcedures. I think we can re-use the same query, as long as we change the restriction from ALIASTYPE = 'P' to ALIASTYPE = 'F'.
I'm wondering if it is a good idea to select JAVACLASSNAME as REMARKS. But since this is not done for getProcedures it may not be a good idea to do it here either...
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12374100 ]
Knut Anders Hatlen commented on DERBY-924:
------------------------------------------
Committed revision 393304.
I made some small changes to the patch before committing it:
- two of the jdk16 canons touched by the patch were removed by the
DERBY-1178 fix
- updated jdk13 canon for metadata.java on DerbyNetClient
I still have one minor question about the patch. getFunctionsX() ends
with these two lines:
lastGetProceduresResultSet_ = executeCatalogQuery(cs);
return lastGetProceduresResultSet_;
Should this have been lastGetFunctionsResultSet_ instead? Not that it
matters, since none of the lastGetXXXResultSet_ variables seem to have
any other purpose than ensuring that a lot of garbage is kept on the
heap.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derby-924.v3.diff, derby-924.v3.report.txt, derby-924.v3.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12368123 ]
Dyre Tjeldvoll commented on DERBY-924:
--------------------------------------
Yes, I see that those links say VARCHAR.
I got VARCHAR(254) from "ODBC 3.5 Developer's Guide" by Roger E. Sanders, McGraw-Hill, (page 836). In the text it says "Adapted from the table on pages 878-879 of Microsoft ODBC 3.0 Software Development Kit & Programmer's reference".
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by Knut Anders Hatlen <Kn...@Sun.COM>.
"Dyre Tjeldvoll (JIRA)" <de...@db.apache.org> writes:
> [ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
>
> Dyre Tjeldvoll updated DERBY-924:
> ---------------------------------
>
> Attachment: derby-924.v3.diff
> derby-924.v3.stat
> derby-924.v3.report.txt
>
> Third version of the patch which addresses the review
> comments. getFunctions is now tested with all jvm versions, and new
> master for the Upgrade test is included.
I will review the patch and intend to commit it.
--
Knut Anders
[jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll updated DERBY-924:
---------------------------------
Attachment: derby-924.v3.diff
derby-924.v3.stat
derby-924.v3.report.txt
Third version of the patch which addresses the review comments. getFunctions is now tested with all jvm versions, and new master for the Upgrade test is included.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derby-924.v3.diff, derby-924.v3.report.txt, derby-924.v3.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll updated DERBY-924:
---------------------------------
Attachment: derby-924.v2.diff
derby-924.v2.stat
derbyall_report.txt
Attaching new patch (derby-924.v2) that also implements getFunctions() in the client (through a stored procedure). Added a new test case to metadata.java to ensure that this is tested in the upgrade test. The new upgrade test ran successfully. Please review, thanks.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, derby-924.v2.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll reassigned DERBY-924:
------------------------------------
Assign To: Dyre Tjeldvoll
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12368493 ]
Rick Hillegas commented on DERBY-924:
-------------------------------------
Looks clean to me. Derbyall passes modulo the expected failure in wisconsin. The jdbc4 tests also pass modulo the mustang timestamp formatting problem. I have checked in this patch as subversion revision 382379.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=all ]
Dyre Tjeldvoll resolved DERBY-924:
----------------------------------
Fix Version: 10.2.0.0
Resolution: Fixed
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-924) new JDBC4 metadata API getFunctions()
needs to be implemented
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12368112 ]
Dyre Tjeldvoll commented on DERBY-924:
--------------------------------------
Actually, my prvious comment was wrong. getProcedures returns CAST ((JAVACLASSNAME || '.' || ALIASINFO->getMethodName()) AS VARCHAR(32672)) AS REMARKS, so I'll use that for getFunctions() as well.
There is a comment in metadata.properties saying:
# 'REMARKS' column is VARCHAR(32672), which is the max length allowed
# for a VARCHAR. This is because Java methods with the complete
# package name plus possible signature can grow to be rather long.
That is probably true, but ODBC 2.0 SQLProcedures specifies, that this column should be VARCHAR(254). But I guess it is better to be consitent with the existing getProcedures() implementation.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
>
> For now I am implementing this to return empty result set so at least we're compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira