You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "macha64 (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 11:59:18 UTC
[jira] [Created] (WW-3801) FileUploadInterceptor does not clean up
temporary files
FileUploadInterceptor does not clean up temporary files
-------------------------------------------------------
Key: WW-3801
URL: https://issues.apache.org/jira/browse/WW-3801
Project: Struts 2
Issue Type: Bug
Components: Core Interceptors
Affects Versions: 2.3.1.2, 2.2.3
Environment: JDK 1.6.0_31, Tomcat 7.0.25
Reporter: macha64
Priority: Minor
In WW-3490, it solved "clean up exception" issue.
then clean up code went to FilterDispatcher.
but FilterDispatcher is deprecated.
I usually use StrutsPrepareAndExecuteFilter.
in that case temporary file was not removed.
I found another problem.
I uploaded file with cgi parameters.
cgi parameter became a temporary file,
and those files were not removed.
for example ...
<form action="..." method="post" enctype="multipart/form-data">
<input type="file" name="uploadFile" />
<input type="text" name="data1" value="FOO"/>
<input type="text" name="data2" value="BAR"/>
</form>
remained tmp file
[upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
FOO
[upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3801) FileUploadInterceptor does not clean
up temporary files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258658#comment-13258658 ]
Hudson commented on WW-3801:
----------------------------
Integrated in Struts2 #462 (See [https://builds.apache.org/job/Struts2/462/])
WW-3801 adds logic to clean ups uploaded files (Revision 1328528)
Result = SUCCESS
lukaszlenart :
Files :
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ng/PrepareOperations.java
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem(move to WW-3802).
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3801) FileUploadInterceptor does not clean up
temporary files
Posted by "macha64 (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
macha64 updated WW-3801:
------------------------
Description:
In WW-3490, it solved "clean up exception" issue.
then clean up code went to FilterDispatcher.
but FilterDispatcher is deprecated.
I usually use StrutsPrepareAndExecuteFilter.
in that case temporary file was not removed.
I found another problem(move to WW-3802).
I uploaded file with cgi parameters.
cgi parameter became a temporary file,
and those files were not removed.
for example ...
<form action="..." method="post" enctype="multipart/form-data">
<input type="file" name="uploadFile" />
<input type="text" name="data1" value="FOO"/>
<input type="text" name="data2" value="BAR"/>
</form>
remained tmp file
[upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
FOO
[upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
BAR
was:
In WW-3490, it solved "clean up exception" issue.
then clean up code went to FilterDispatcher.
but FilterDispatcher is deprecated.
I usually use StrutsPrepareAndExecuteFilter.
in that case temporary file was not removed.
I found another problem.
I uploaded file with cgi parameters.
cgi parameter became a temporary file,
and those files were not removed.
for example ...
<form action="..." method="post" enctype="multipart/form-data">
<input type="file" name="uploadFile" />
<input type="text" name="data1" value="FOO"/>
<input type="text" name="data2" value="BAR"/>
</form>
remained tmp file
[upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
FOO
[upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
BAR
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem(move to WW-3802).
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WW-3801) FileUploadInterceptor does not clean up
temporary files
Posted by "Lukasz Lenart (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart reassigned WW-3801:
---------------------------------
Assignee: Lukasz Lenart
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem.
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3801) FileUploadInterceptor does not clean
up temporary files
Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257250#comment-13257250 ]
Lukasz Lenart commented on WW-3801:
-----------------------------------
Ok, thanks! So basically, the problem is with the new filters which don't clean up uploaded files as FilterDispatcher is doing.
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem(move to WW-3802).
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3801) FileUploadInterceptor does not clean
up temporary files
Posted by "macha64 (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257168#comment-13257168 ]
macha64 commented on WW-3801:
-----------------------------
I used FilterDispatcher,
upload file was removed.
but cgi parameter tmp file were not removed.
I created WW-3802 for cgi parameter tmp file issue.
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem.
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WW-3801) FileUploadInterceptor does not clean up
temporary files
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart resolved WW-3801.
-------------------------------
Resolution: Fixed
Done, please test with the latest snapshot!
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem(move to WW-3802).
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3801) FileUploadInterceptor does not clean up
temporary files
Posted by "Lukasz Lenart (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart updated WW-3801:
------------------------------
Fix Version/s: 2.3.4
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem.
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3801) FileUploadInterceptor does not clean
up temporary files
Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256532#comment-13256532 ]
Lukasz Lenart commented on WW-3801:
-----------------------------------
Even if you used FilterDispatcher ? And please address one problem per issue, it's much more easy to handle discussion and solution.
> FileUploadInterceptor does not clean up temporary files
> -------------------------------------------------------
>
> Key: WW-3801
> URL: https://issues.apache.org/jira/browse/WW-3801
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.2.3, 2.3.1.2
> Environment: JDK 1.6.0_31, Tomcat 7.0.25
> Reporter: macha64
> Priority: Minor
> Fix For: 2.3.4
>
>
> In WW-3490, it solved "clean up exception" issue.
> then clean up code went to FilterDispatcher.
> but FilterDispatcher is deprecated.
> I usually use StrutsPrepareAndExecuteFilter.
> in that case temporary file was not removed.
> I found another problem.
> I uploaded file with cgi parameters.
> cgi parameter became a temporary file,
> and those files were not removed.
> for example ...
> <form action="..." method="post" enctype="multipart/form-data">
> <input type="file" name="uploadFile" />
> <input type="text" name="data1" value="FOO"/>
> <input type="text" name="data2" value="BAR"/>
> </form>
> remained tmp file
> [upload_47c7ddf7_136bf8a8b3b__8000_00000002.tmp]
> FOO
> [upload_47c7ddf7_136bf8a8b3b__8000_00000003.tmp]
> BAR
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira