You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2012/08/17 00:26:37 UTC
[jira] [Created] (HBASE-6598) Combine Master Metrics into a single
class.
Elliott Clark created HBASE-6598:
------------------------------------
Summary: Combine Master Metrics into a single class.
Key: HBASE-6598
URL: https://issues.apache.org/jira/browse/HBASE-6598
Project: HBase
Issue Type: Sub-task
Reporter: Elliott Clark
Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6598) Combine Master Metrics into a
single class.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437184#comment-13437184 ]
Hadoop QA commented on HBASE-6598:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541435/HBASE-6598-0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.metrics.MasterMetricsSourceImplTest
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2607//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2607//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2607//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2607//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2607//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2607//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2607//console
This message is automatically generated.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6598) Combine Master Metrics into a
single class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442776#comment-13442776 ]
Elliott Clark commented on HBASE-6598:
--------------------------------------
Thanks.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch, HBASE-6598-2.patch, HBASE-6598-3.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6598:
---------------------------------
Status: Patch Available (was: Open)
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6598) Combine Master Metrics into a
single class.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440130#comment-13440130 ]
Hadoop QA commented on HBASE-6598:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542079/HBASE-6598-3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2659//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2659//console
This message is automatically generated.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch, HBASE-6598-2.patch, HBASE-6598-3.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6598) Combine Master Metrics into a
single class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442268#comment-13442268 ]
Elliott Clark commented on HBASE-6598:
--------------------------------------
In jmx it will be under: Hadoop -> HBase -> HRegionServer.
The new metrics has context and jmx context. Context is used with the hadoop-metrics2.properties file to determine where to send mbean. The jmx context is where in jconsole data will be pushed.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch, HBASE-6598-2.patch, HBASE-6598-3.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6598) Combine Master Metrics into a
single class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438029#comment-13438029 ]
Elliott Clark commented on HBASE-6598:
--------------------------------------
Everything runs clean on my local machine once I give maven a little more memory.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch, HBASE-6598-2.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6598:
---------------------------------
Attachment: HBASE-6598-3.patch
rebase to trunk
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch, HBASE-6598-2.patch, HBASE-6598-3.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6598:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Elliott.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch, HBASE-6598-2.patch, HBASE-6598-3.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6598:
---------------------------------
Status: Patch Available (was: Open)
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6598:
---------------------------------
Attachment: HBASE-6598-2.patch
Attaching again trying to get hadoop qa to come back around.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch, HBASE-6598-2.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6598:
---------------------------------
Attachment: HBASE-6598-0.patch
Just cleaning up the interface exposed the outside world through metrics.
To the external developer none of the metrics looked any more dynamic than others so they shouldn't be split. This patch should make everything a little easier to use from the jmx side.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark reassigned HBASE-6598:
------------------------------------
Assignee: Elliott Clark
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6598:
---------------------------------
Status: Open (was: Patch Available)
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6598) Combine Master Metrics into a single
class.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6598:
---------------------------------
Attachment: HBASE-6598-1.patch
Fix tests that weren't using the new factory.
> Combine Master Metrics into a single class.
> -------------------------------------------
>
> Key: HBASE-6598
> URL: https://issues.apache.org/jira/browse/HBASE-6598
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6598-0.patch, HBASE-6598-1.patch
>
>
> Rather than an MBean and a dynamic source. Lets use just one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira