You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/06 13:01:48 UTC
[GitHub] [incubator-doris] zengwenjie128 opened a new pull request, #9976: Remove the redundant "this."
zengwenjie128 opened a new pull request, #9976:
URL: https://github.com/apache/incubator-doris/pull/9976
# Proposed changes
Issue Number: no relative issue
## Problem Summary:
In Java, we can use `this.` to access class member variables .
But, in most scenario, it's redundant. We can remove it from non-constructor functions.
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No
3. Has document been added or modified: No
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zengwenjie128 commented on a diff in pull request #9976: Remove the redundant "this."
Posted by GitBox <gi...@apache.org>.
zengwenjie128 commented on code in PR #9976:
URL: https://github.com/apache/incubator-doris/pull/9976#discussion_r890127848
##########
fe/fe-core/src/main/java/org/apache/doris/task/AgentBatchTask.java:
##########
@@ -64,7 +64,7 @@ public class AgentBatchTask implements Runnable {
private Map<Long, List<AgentTask>> backendIdToTasks;
public AgentBatchTask() {
- this.backendIdToTasks = new HashMap<Long, List<AgentTask>>();
+ backendIdToTasks = new HashMap<Long, List<AgentTask>>();
}
Review Comment:
Thanks!Let me remove these spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener closed pull request #9976: Remove the redundant "this."
Posted by GitBox <gi...@apache.org>.
jackwener closed pull request #9976: Remove the redundant "this."
URL: https://github.com/apache/doris/pull/9976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on a diff in pull request #9976: Remove the redundant "this."
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #9976:
URL: https://github.com/apache/incubator-doris/pull/9976#discussion_r890126982
##########
fe/fe-core/src/main/java/org/apache/doris/task/AgentBatchTask.java:
##########
@@ -64,7 +64,7 @@ public class AgentBatchTask implements Runnable {
private Map<Long, List<AgentTask>> backendIdToTasks;
public AgentBatchTask() {
- this.backendIdToTasks = new HashMap<Long, List<AgentTask>>();
+ backendIdToTasks = new HashMap<Long, List<AgentTask>>();
}
Review Comment:
redundant space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org