You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by PaulElschot <gi...@git.apache.org> on 2014/05/19 00:10:35 UTC
[GitHub] lucene-solr pull request: Add PrefillTokenStream in analysis commo...
GitHub user PaulElschot opened a pull request:
https://github.com/apache/lucene-solr/pull/53
Add PrefillTokenStream in analysis common module
This class is taken from the proposed label module, the tests there also pass when using this.
It is a token stream that can be prefilled by adding token states, much like CachingTokenFilter and TeeSinkTokenFilter.SinkTokenStream, but the addState method here is public.
It is used in the label module to build token streams.
Some questions:
Is this a good way to build multiple streams from a single input stream?
When not, I'll need to use another way to build token streams in the label module.
This duplicates some code in CachingTokenFilter and TeeSinkTokenFilter.SinkTokenStream.
Should this rather be a superclass of TeeSinkTokenFilter.SinkTokenStream? In that case an extra non final class would also be needed to allow the inheritance, because an instantiated TokenStream subclass must be final.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulElschot/lucene-solr pfts-201405a
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit f8a6af5f1b0f07e6e8afdcd6e120a41c932a2600
Author: Paul Elschot <pa...@gmail.com>
Date: 2014-05-18T21:53:21Z
Add PrefillTokenStream in analysis common module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #53: [SOLR-9341] GC logs go to SOLR_LOGS_DIR on Windows
Posted by afscrome <gi...@git.apache.org>.
Github user afscrome commented on the issue:
https://github.com/apache/lucene-solr/pull/53
Fixed in 33db4de4d7d5e325f8bfd886d3957735b33310a8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #53: GC logs go to SOLR_LOGS_DIR on Windows
Posted by tflobbe <gi...@git.apache.org>.
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/53
This PR doesn't seem to be linked to any Jira. Is there one? If you include the Jira issue id in the title of the PR it will automatically show in Jira (e.g. https://issues.apache.org/jira/browse/SOLR-9279 ). You can create a new Jira issue if there isn't one for this fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Add PrefillTokenStream in analysis commo...
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot closed the pull request at:
https://github.com/apache/lucene-solr/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #53: [SOLR-9341] GC logs go to SOLR_LOGS_DIR on Win...
Posted by afscrome <gi...@git.apache.org>.
Github user afscrome closed the pull request at:
https://github.com/apache/lucene-solr/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Add PrefillTokenStream in analysis commo...
Posted by uschindler <gi...@git.apache.org>.
Github user uschindler commented on the pull request:
https://github.com/apache/lucene-solr/pull/53#issuecomment-43470477
If incrementToken() is final its enough to hold contract, so an additional class would not be needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Add PrefillTokenStream in analysis commo...
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot commented on the pull request:
https://github.com/apache/lucene-solr/pull/53#issuecomment-43516617
Ok, I'll refactor and open a lucene issue for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Add PrefillTokenStream in analysis commo...
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot commented on the pull request:
https://github.com/apache/lucene-solr/pull/53#issuecomment-43547808
The lucene issue for this is LUCENE-5687, https://issues.apache.org/jira/browse/LUCENE-5687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #53: [SOLR-9341] GC logs go to SOLR_LOGS_DIR on Windows
Posted by afscrome <gi...@git.apache.org>.
Github user afscrome commented on the issue:
https://github.com/apache/lucene-solr/pull/53
Sorry, I didn't realise a jira issue was required - it's not completely clear from https://wiki.apache.org/solr/HowToContribute#Working_with_GitHub .
I've created a new issue and linked it in the PR title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org