[GitHub] [hbase] ndimiduk commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters
URL: https://github.com/apache/hbase/pull/830#discussion_r347651220
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
 ##########
 @@ -3051,6 +3053,44 @@ public static ProcedureDescription buildProcedureDescription(String signature, S
     return builder.build();
   }
 
+  /**
+   * Get the Meta region state from the passed data bytes. Can handle both old and new style
+   * server names.
+   * @param data protobuf serialized data with meta server name.
+   * @param replicaId replica ID for this region
+   * @return RegionState instance corresponding to the serialized data.
+   * @throws DeserializationException if the data is invalid.
+   */
+  public static RegionState parseMetaRegionStateFrom(final byte[] data, int replicaId)
 
 Review comment:
   Looks like there's no unit tests covering this new method, nor the `parseServerNameFrom` that you wrap. This parsing business seems pretty critical to correctness, so it would be nice to see direct unit test coverage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services