[jira] [Commented] (FLINK-7375) Remove ActorGateway from JobClient

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116506#comment-16116506 ] 

ASF GitHub Bot commented on FLINK-7375:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4486

    [FLINK-7375] Replace ActorGateway with JobManagerGateway in JobClient

    ## What is the purpose of the change
    
    In order to make the JobClient code independent of Akka, this PR replaces the
    ActorGateway parameters by JobManagerGateway. AkkaJobManagerGateway is the
    respective implementation of the JobManagerGateway for Akka. Moreover, this
    PR introduces useful ExceptionUtils method for handling of Future exceptions.
    Additionally, the SerializedThrowable has been moved to flink-core.
    
    This PR is based on #4483.
    
    ## Brief change log
    
    - Replace `ActorGateway` by `JobManagerGateway` in `JobClient`
    - `AkkaJobManagerGateway` is the Akka based implementation of `JobManagerGateway`
    - `ExceptionUtils` contain new functions to handle future exceptions
    - `SerializedThrowable` has been moved to `flink-core`
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeActorGatewayClient

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4486
    
----
commit 50d304647e65be90937809d71cef87608f60b9ce
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-04T22:28:15Z

    [FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
    
    The JobGraph has an unncessary dependency on the ActorGateway via its JobGraph#uploadUserJars method. In
    order to get rid of this dependency for future Flip-6 changes, this commit retrieves the BlobServer's
    address beforehand and directly passes it to this method.

commit e4596e060b471464064de142d16d86c0a52ca078
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-06T15:56:41Z

    [FLINK-7375] Replace ActorGateway with JobManagerGateway in JobClient
    
    In order to make the JobClient code independent of Akka, this PR replaces the
    ActorGateway parameters by JobManagerGateway. AkkaJobManagerGateway is the
    respective implementation of the JobManagerGateway for Akka. Moreover, this
    PR introduces useful ExceptionUtils method for handling of Future exceptions.
    Additionally, the SerializedThrowable has been moved to flink-core.

----


> Remove ActorGateway from JobClient
> ----------------------------------
>
>                 Key: FLINK-7375
>                 URL: https://issues.apache.org/jira/browse/FLINK-7375
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> Remove {{ActorGateway}} dependency from {{JobClient}}. This will ease the transition to the Flip-6 code base because we can reuse the {{JobClient}} code.
> I propose to replace the {{ActorGateway}} by a more strictly typed {{JobManagerGateway}} which will be extended by the Flip-6 {{JobMasterGateway}}. This will allow to decouple the {{JarRunHandler}} from the {{ActorGateway}} as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)