You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/17 02:11:55 UTC
[GitHub] [spark] ulysses-you opened a new pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
ulysses-you opened a new pull request #31856:
URL: https://github.com/apache/spark/pull/31856
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Skip capture maven repo config for views.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Due to the bad network, we always use the thirdparty maven repo to run test. e.g.,
```
build/sbt "test:testOnly *SQLQueryTestSuite" -Dspark.sql.maven.additionalRemoteRepositories=xxxxx
```
It's failed with such error msg
```
[info] - show-tblproperties.sql *** FAILED *** (128 milliseconds)
[info] show-tblproperties.sql
[info] Expected "...rredTempViewNames [][]", but got "...rredTempViewNames [][
[info] view.sqlConfig.spark.sql.maven.additionalRemoteRepositories xxxxx]" Result did not match for query #6
[info] SHOW TBLPROPERTIES view (SQLQueryTestSuite.scala:464)
```
It's not necessary to capture the maven config to view since it's a session level config.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
manual test pass
```
build/sbt "test:testOnly *SQLQueryTestSuite" -Dspark.sql.maven.additionalRemoteRepositories=xxx
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801040832
Thanks, Merged to master~
~~BTW, is the second run of the pr merge tool not able to change target branch~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801116047
> after merging to master, the script will ask you if you want to merge it to other branches.
Yeah, I have seen this.
After if I reply `n` to it and I regret it, is there any chance for me to go back?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn edited a comment on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801069433
## A brief history w/ running ./dev/merge_spark_pr.py for the second round after this PR is in master
```
Which pull request would you like to merge? (e.g. 34): 31856
```
**In this part, I was expecting it would ask me to enter the targeting branch**, but it went to master directly
```
Pull request 31856 is not mergeable in its current form.
Continue? (experts only!) (y/n): y
=== Pull Request #31856 ===
title [SPARK-34766][SQL] Do not capture maven config for views
source ulysses-you/skip-maven-config
target master
url https://api.github.com/repos/apache/spark/pulls/31856
Proceed with merging pull request #31856? (y/n):
``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801132328
Er.. I was expecting something like
Hi @ulysses-you, sorry for my mistake, can we make a backport to 3.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-800912628
cc @yaooqinn @maropu @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801125831
No, now we need to create a new PR for 3.1...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801072581
after merging to master, the script will ask you if you want to merge it to other branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801032440
Yes, I have taken my first shot with my own PR(which is a follow-up, and no need for the JIRA side). Let me merge this to test the full workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801681093
created [#31879](https://github.com/apache/spark/pull/31879)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-800765092
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40716/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-800768241
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40716/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-800771397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801030245
@yaooqinn Have you already tried to merge a commit? If not yet, please do it for your practice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-800771398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #31856:
URL: https://github.com/apache/spark/pull/31856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn edited a comment on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801040832
Thanks, Merged to master~
BTW, is the second run of the pr merge tool not able to change target branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801050691
> BTW, is the second run of the pr merge tool not able to change target branch
Why can't you select a target branch? It raises an error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-800922586
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31856: [SPARK-34766][SQL] Do not capture maven config for views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31856:
URL: https://github.com/apache/spark/pull/31856#issuecomment-801069433
## A brief history w/ running ./dev/merge_spark_pr.py for the second round after this PR is in master
```
Which pull request would you like to merge? (e.g. 34): 31856
```
** In this part, I was expecting it would ask me to enter the targeting branch**, but it went to master directly
```
Pull request 31856 is not mergeable in its current form.
Continue? (experts only!) (y/n): y
=== Pull Request #31856 ===
title [SPARK-34766][SQL] Do not capture maven config for views
source ulysses-you/skip-maven-config
target master
url https://api.github.com/repos/apache/spark/pulls/31856
Proceed with merging pull request #31856? (y/n):
``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org