You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/13 17:55:33 UTC

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15761: [OpPerf] Handle positional arguments

apeforest commented on a change in pull request #15761: [OpPerf] Handle positional arguments
URL: https://github.com/apache/incubator-mxnet/pull/15761#discussion_r313532616
 
 

 ##########
 File path: benchmark/opperf/utils/benchmark_utils.py
 ##########
 @@ -28,40 +28,56 @@
 
 def _prepare_op_inputs(inputs, run_backward, dtype, ctx):
     kwargs_list = []
+    args_list = []
 
     for inp in inputs:
         kwargs = {}
         for key, value in inp.items():
-            if key in PARAMS_OF_TYPE_NDARRAY:
+            if key in PARAMS_OF_TYPE_NDARRAY and key=='args':
+                args_list.append(get_mx_ndarray(ctx=ctx, in_tensor=value,
+                                             dtype=dtype,
 
 Review comment:
   nit: indent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services