[jira] [Commented] (SINGA-59) Remove dependency on gflags

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SINGA-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700669#comment-14700669 ] 

ASF subversion and git services commented on SINGA-59:
------------------------------------------------------

Commit f2b0aef127cb8bca17173374ea8846d8deb59be3 in incubator-singa's branch refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=f2b0aef ]

SINGA-59 Remove dependency on gflags

remove gflag in tool.cc

updated Dirver class and example main file to remove dependency on gflags.
All flags should be passed to the main func as -argname [argvalue], where argvalue is optional.

Users must pass the job conf path, which includes at least the cluster setting. the sing-run.sh should
add -singa_conf <conf_path> -singa_job <jobid> to the arglist.

the user provided argument -conf path is changed to absolute path and appended to the end of arglist

Update configure and Makefile related files to remove gflags


> Remove dependency on gflags
> ---------------------------
>
>                 Key: SINGA-59
>                 URL: https://issues.apache.org/jira/browse/SINGA-59
>             Project: Singa
>          Issue Type: Improvement
>            Reporter: wangwei
>
> gflags is used in SINGA for parsing command line arguments.
> But it is an external library. Users have to install it before compiling SINGA.
> To make the installation of SINGA easier, this ticket is going to remove the dependency of gflags. 
> SINGA and users then have to parse the command line arguments explicitly.
> E.g., in Diver::Init(), SINGA will parse the *job* ID and *sing_conf* path (which is specified by the singa-run.sh script). The main.cc needs to parse the *conf* argument for job configuration file. If users write their own main.cc, then they need to parse their own arguments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)