You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@qpid.apache.org by Michael Ivanov <iv...@logit-ag.de> on 2018/03/07 14:35:55 UTC

qpidd crash

Greetings,

qpidd 1.37 seems to have a bug in rdma_wrap.cpp, function deviceCount().
Originally it looked like follows:

   ::ibv_free_device_list(::ibv_get_device_list(&count));

And qpidd crashed with segv on my system (debian sid).

I changed it as follows:

    int deviceCount() {
        struct ibv_device **list;
        int count;

        if ((list = ::ibv_get_device_list(&count)))
           ::ibv_free_device_list(list);
        return count;
    }

and it runs now.

Best regards,
-- 
Michael Ivanov

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org

Re: qpidd crash

Posted by Gordon Sim <gs...@redhat.com>.
On 07/03/18 16:38, Michael Ivanov wrote:
> No problem, just tell me how to access proper page in jira.

https://issues.apache.org/jira/projects/QPID/issues, if you login there 
should be a 'create' button in red that allows you to create a new JIRA, 
and then on the issue there will be a 'More' dropdown which lets you 
attach a patch. Thanks again!

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org

Re: qpidd crash

Posted by Michael Ivanov <iv...@isle.spb.ru>.
No problem, just tell me how to access proper page in jira.

07.03.2018 19:17, Gordon Sim пишет:
> On 07/03/18 14:35, Michael Ivanov wrote:
>> Greetings,
>>
>> qpidd 1.37 seems to have a bug in rdma_wrap.cpp, function deviceCount().
>> Originally it looked like follows:
>>
>>     ::ibv_free_device_list(::ibv_get_device_list(&count));
>>
>> And qpidd crashed with segv on my system (debian sid).
>>
>> I changed it as follows:
>>
>>      int deviceCount() {
>>          struct ibv_device **list;
>>          int count;
>>
>>          if ((list = ::ibv_get_device_list(&count)))
>>             ::ibv_free_device_list(list);
>>          return count;
>>      }
>>
>> and it runs now.
> 
> Thanks! Would you mind attaching that as a patch to a JIRA (or submitting a PR if thats easier). I can then get it committed.
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org

Re: qpidd crash

Posted by Gordon Sim <gs...@redhat.com>.
On 07/03/18 14:35, Michael Ivanov wrote:
> Greetings,
> 
> qpidd 1.37 seems to have a bug in rdma_wrap.cpp, function deviceCount().
> Originally it looked like follows:
> 
>     ::ibv_free_device_list(::ibv_get_device_list(&count));
> 
> And qpidd crashed with segv on my system (debian sid).
> 
> I changed it as follows:
> 
>      int deviceCount() {
>          struct ibv_device **list;
>          int count;
> 
>          if ((list = ::ibv_get_device_list(&count)))
>             ::ibv_free_device_list(list);
>          return count;
>      }
> 
> and it runs now.

Thanks! Would you mind attaching that as a patch to a JIRA (or 
submitting a PR if thats easier). I can then get it committed.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org