You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/04 18:27:41 UTC
[jira] [Commented] (THRIFT-4165) C++ build has many warnings under
c++03 due to recent changes, cmake needs better platform-independent
language level control
[ https://issues.apache.org/jira/browse/THRIFT-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955563#comment-15955563 ]
ASF GitHub Bot commented on THRIFT-4165:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1236
THRIFT-4165: better cmake support for C++ language level, fixed compiler warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1236
----
commit 34b22f9276509827b385125dd3acf9ca5befff60
Author: James E. King, III <ji...@simplivity.com>
Date: 2017-04-04T17:04:29Z
THRIFT-4165: better cmake support for C++ language level selection; fixed compiler warnings
----
> C++ build has many warnings under c++03 due to recent changes, cmake needs better platform-independent language level control
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4165
> URL: https://issues.apache.org/jira/browse/THRIFT-4165
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.11.0
> Environment: Ubuntu 14.04 with gcc-4.6 (c++03)
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> When not using -std=c++11 there are a number of build warnings coming out of gcc-4.6.x. These can be turned off specifically if C++11 support is not enabled for the compiler, but the compiler allows some C99 extensions (with warning).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)