You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/07 06:36:15 UTC
[GitHub] [airflow] potiuk opened a new pull request #15710: Fixes syntax of terraform script.
potiuk opened a new pull request #15710:
URL: https://github.com/apache/airflow/pull/15710
Latest pygments version does not render properly the
syntax where `{}` is used (terraform expects this to be
separated by EOL.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15710: Fixes syntax of terraform script.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15710:
URL: https://github.com/apache/airflow/pull/15710#issuecomment-834107643
@mik-laj - I believe this was reason for the
```
173 | ``Service Account Token Creator`` role granted on account A, and account A has this role on account
174 | B, then we are able to impersonate account B.
175 |
176 | For example, with the following ``terraform`` setup...
177 |
>178 | .. code-block:: terraform
179 |
180 | terraform {
181 | required_version = "> 0.11.14"
182 | }
183 | provider "google" {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #15710: Fixes syntax of terraform script.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #15710:
URL: https://github.com/apache/airflow/pull/15710#issuecomment-834107643
@mik-laj - I believe this was reason for the
```
WARNING: Could not lex literal_block as "terraform". Highlighting skipped.
File path: apache-airflow-providers-google/connections/gcp.rst (178)
173 | ``Service Account Token Creator`` role granted on account A, and account A has this role on account
174 | B, then we are able to impersonate account B.
175 |
176 | For example, with the following ``terraform`` setup...
177 |
>178 | .. code-block:: terraform
179 |
180 | terraform {
181 | required_version = "> 0.11.14"
182 | }
183 | provider "google" {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15710: Fixes syntax of terraform script.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15710:
URL: https://github.com/apache/airflow/pull/15710#issuecomment-834112083
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15710: Fixes syntax of terraform script.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15710:
URL: https://github.com/apache/airflow/pull/15710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org