You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Quintin Beukes (JIRA)" <ji...@apache.org> on 2009/10/22 13:37:59 UTC
[jira] Created: (OPENEJB-1092) Singleton @Startup Support for
Geronimo
Singleton @Startup Support for Geronimo
---------------------------------------
Key: OPENEJB-1092
URL: https://issues.apache.org/jira/browse/OPENEJB-1092
Project: OpenEJB
Issue Type: Bug
Components: deployment
Affects Versions: 3.1.2
Reporter: Quintin Beukes
Fix For: 3.1.x, 3.1.2
Geronimo doesn't support Singletons, even though 3.1.2 OpenEJB is used. This is mainly due to the deployment integration being incomplete and a ThreadContextListener which causes a deadlock.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1092) Singleton @Startup Support for
Geronimo
Posted by "Quintin Beukes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Quintin Beukes updated OPENEJB-1092:
------------------------------------
Attachment: (was: geronimo-singleton-support-openejb.patch)
> Singleton @Startup Support for Geronimo
> ---------------------------------------
>
> Key: OPENEJB-1092
> URL: https://issues.apache.org/jira/browse/OPENEJB-1092
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 3.1.2
> Reporter: Quintin Beukes
> Fix For: 3.1.2, 3.1.x
>
>
> Geronimo doesn't support Singletons, even though 3.1.2 OpenEJB is used. This is mainly due to the deployment integration being incomplete and a ThreadContextListener which causes a deadlock.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1092) Singleton @Startup Support for
Geronimo
Posted by "Quintin Beukes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Quintin Beukes updated OPENEJB-1092:
------------------------------------
Attachment: geronimo-singleton-support-openejb.patch
Updated the patch.
Still provides the startup responsibility for Geronimo as the previous.
This one includes a fix for the setAccessTimeout(Duration) method in the Singleton container. If an access timeout doesn't specify a unit, then the duration.unit is null, which causes the ReadWriteLock to throw a NullPointerException. Updated the setAccessTimeout(Duration) method to default to TimeUnit.SECONDS if the unit wasn't specified.
Still required for GERONIMO-4918 to work.
> Singleton @Startup Support for Geronimo
> ---------------------------------------
>
> Key: OPENEJB-1092
> URL: https://issues.apache.org/jira/browse/OPENEJB-1092
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 3.1.2
> Reporter: Quintin Beukes
> Fix For: 3.1.2, 3.1.x
>
> Attachments: geronimo-singleton-support-openejb.patch
>
>
> Geronimo doesn't support Singletons, even though 3.1.2 OpenEJB is used. This is mainly due to the deployment integration being incomplete and a ThreadContextListener which causes a deadlock.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1092) Singleton @Startup Support for
Geronimo
Posted by "Quintin Beukes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Quintin Beukes updated OPENEJB-1092:
------------------------------------
Attachment: geronimo-singleton-support-openejb.patch
This patch basically adds a new property to the SingletonContainer called "startupResponsibility" and moves the @Startup logic into a separate method called doLoadOnStartup(CoreDeploymentInfo). Then, this property can be passed into the assembler, to cause the SingletonContainer to not take responsibility for the startup. The property has a default value of "true", meaning any existing implementations will continue to function as before.
This patch makes GERONIMO-4918 possible.
Geronimo's SingletonContainerGBean then sets the "startupResponsibility" property to "false", thus taking over this responsibility. Later on when Geronimo is happy with the deployment of a Singleton bean, it will call the SingletonContainer.doLoadOnStartup(CoreDeploymentInfo) method, to cause the startup to happen.
> Singleton @Startup Support for Geronimo
> ---------------------------------------
>
> Key: OPENEJB-1092
> URL: https://issues.apache.org/jira/browse/OPENEJB-1092
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 3.1.2
> Reporter: Quintin Beukes
> Fix For: 3.1.2, 3.1.x
>
> Attachments: geronimo-singleton-support-openejb.patch
>
>
> Geronimo doesn't support Singletons, even though 3.1.2 OpenEJB is used. This is mainly due to the deployment integration being incomplete and a ThreadContextListener which causes a deadlock.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.