[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.
URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254683792
 
 

 ##########
 File path: daffodil-cli/build.sbt
 ##########
 @@ -71,3 +78,165 @@ rpmRelease := {
 rpmLicense := Some(licenses.value.map { case (n: String, _) => n }.mkString(" and "))
 
 rpmPrefix := Some(defaultLinuxInstallLocation.value)
+
+//
+// Windows configuration
+//
+
+//
+// Here we set the variables that are supported by the SBT WiX plug-in.
+// We also get fairly aggressive in editing/modifying the XML in order
+// to control and use some specific features that are supported by WiX
+// but which are not properly suported by the SBT plug-in. The changes
+// range from deleting an incorrect UI reference to adding whole files
+// to the body of code that is fed to the WiX compiler (candle) and
+// linker (light). We also change some attributes and such with a
+// ReWriter at the end. The comments should, at the very least, allow
+// you to follow the intent of each channge.
+//
 
 Review comment:
   I think I'd remove some of the comments about what code below actually does. Some day we're going to change that code and forget to update this comment and then this comment will be wrong and confusing. Instead of explaining what the code below does, just explain why we do various things. I think you do that sufficiently in the first sentnece (e.g. control features not supported by the plugin).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services