[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16736#discussion_r99979855
  
    --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala ---
    @@ -128,6 +128,21 @@ class ConfigEntrySuite extends SparkFunSuite {
         assert(conf.get(transformationConf) === "bar")
       }
     
    +  test("conf entry: checkValue()") {
    +    def createConf(default: Int): ConfigEntry[Int] =
    +      ConfigBuilder(testKey("checkValue"))
    +        .intConf
    +        .checkValue(value => value >= 0, "value must be non-negative")
    +        .createWithDefault(default)
    +
    +    // this succeeds
    +    createConf(10)
    --- End diff --
    
    this only checks default value, shall we also check `conf.set/get`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org