[GitHub] [dolphinscheduler] tongwl commented on pull request #10096: [Feature][Improvement] Support multi cluster environments - k8s type

[GitBox <gi...@apache.org>]

tongwl commented on PR #10096:
URL: https://github.com/apache/dolphinscheduler/pull/10096#issuecomment-1155955820

   @Amy0104, thank you for your review, very nice catching :) 
   I also have some suggestions, as we are only contributors, not owners, so our new code style is best to refer to the existing code, this will make the project code management clearer. So it would be even better if  all the similar pages using the similar template, this pr front-end code is copied from the cluster page. Obviously, the cluster code can't be recognized by project owners, it does have some small areas that can be optimized. For our contributors, we'd better not be unconventional, but keep the same way of code writing style.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org