You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2011/06/07 01:33:59 UTC
[jira] [Created] (HDFS-2042) Require c99 when building libhdfs
Require c99 when building libhdfs
---------------------------------
Key: HDFS-2042
URL: https://issues.apache.org/jira/browse/HDFS-2042
Project: Hadoop HDFS
Issue Type: Improvement
Components: libhdfs
Reporter: Eli Collins
Priority: Minor
Per the discussion in HDFS-1619, libhdfs uses some c99 features, therefore we should use compile with c99 standard flags (eg c99 or gnu99 when using gcc) when building it. We could do this with autotools via AC_PROG_CC_C99 (which requires a more recent autotools) or by setting CLFAGS in src/c++/libhdfs/configure. We should perhaps rename src/c++ to src/c while we're at it since libhdfs is not written in c++ and libhdfs is the only subdirectory.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2042) Require c99 when building libhdfs
Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045212#comment-13045212 ]
Allen Wittenauer commented on HDFS-2042:
----------------------------------------
Setting of CFLAGS is almost always non-portable.
> Require c99 when building libhdfs
> ---------------------------------
>
> Key: HDFS-2042
> URL: https://issues.apache.org/jira/browse/HDFS-2042
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Eli Collins
> Priority: Minor
>
> Per the discussion in HDFS-1619, libhdfs uses some c99 features, therefore we should use compile with c99 standard flags (eg c99 or gnu99 when using gcc) when building it. We could do this with autotools via AC_PROG_CC_C99 (which requires a more recent autotools) or by setting CLFAGS in src/c++/libhdfs/configure. We should perhaps rename src/c++ to src/c while we're at it since libhdfs is not written in c++ and libhdfs is the only subdirectory.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2042) Require c99 when building libhdfs
Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045235#comment-13045235 ]
Allen Wittenauer commented on HDFS-2042:
----------------------------------------
Agreed. I've got a patch that removes almost all of the GNU-ifications but it is built for 0.20 and needs to get cleaned up.
> Require c99 when building libhdfs
> ---------------------------------
>
> Key: HDFS-2042
> URL: https://issues.apache.org/jira/browse/HDFS-2042
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Eli Collins
> Priority: Minor
>
> Per the discussion in HDFS-1619, libhdfs uses some c99 features, therefore we should use compile with c99 standard flags (eg c99 or gnu99 when using gcc) when building it. We could do this with autotools via AC_PROG_CC_C99 (which requires a more recent autotools) or by setting CLFAGS in src/c++/libhdfs/configure. We should perhaps rename src/c++ to src/c while we're at it since libhdfs is not written in c++ and libhdfs is the only subdirectory.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2042) Require c99 when building libhdfs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045213#comment-13045213 ]
Eli Collins commented on HDFS-2042:
-----------------------------------
Our configure file already has compiler-specific sections for setting cflags for particular compilers, but I think we should do this via autotools.
> Require c99 when building libhdfs
> ---------------------------------
>
> Key: HDFS-2042
> URL: https://issues.apache.org/jira/browse/HDFS-2042
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Eli Collins
> Priority: Minor
>
> Per the discussion in HDFS-1619, libhdfs uses some c99 features, therefore we should use compile with c99 standard flags (eg c99 or gnu99 when using gcc) when building it. We could do this with autotools via AC_PROG_CC_C99 (which requires a more recent autotools) or by setting CLFAGS in src/c++/libhdfs/configure. We should perhaps rename src/c++ to src/c while we're at it since libhdfs is not written in c++ and libhdfs is the only subdirectory.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira