Re: [PR] HDDS-12239. Volume should not be marked as unhealthy when disk full [ozone]

["sumitagrawl (via GitHub)" <gi...@apache.org>]

sumitagrawl commented on code in PR #7830:
URL: https://github.com/apache/ozone/pull/7830#discussion_r1987041410


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolume.java:
##########
@@ -614,6 +614,15 @@ public synchronized VolumeCheckResult check(@Nullable Boolean unused)
       return VolumeCheckResult.HEALTHY;
     }
 
+    // At least some space required to check disk read/write
+    // If there are not enough space remaining,
+    // to avoid volume failure we can ignore checking disk read/write
+    int hundredMB = 100 * 1024 * 1024;

Review Comment:
   this can be converted to constant - private static final 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org