[GitHub] [incubator-dubbo] OrDTesters commented on pull request #2807: Fixing test-order dependency in org.apache.dubbo.rpc.cluster.StickyTest

["OrDTesters (GitHub)" <gi...@apache.org>]

When either testStickyForceCheck or testStickyNoCheck runs, they eventually end up using an instance of RoundRobinLoadBalance, which is obtained and shared between the two tests through the ExtensionLoader, accessed using the LoadBalance.class as key. In between the two runs, one of the shared RoundRobinLoadBalance instance's internal map fields changes. The change is such that if testStickyNoCheck runs after testStickyForceCheck, the assertion for testStickyNoCheck fails. The goal of resetting is to make sure the two tests do not end up using the same RoundRobinLoadBalance instance when they run.

I would be happy to discuss any other ways of approaching this problem.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2807 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org