[jira] [Commented] (HBASE-24722) Address hbase-shell commands with unintentional return values

["Michael Stack (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160144#comment-17160144 ] 

Michael Stack commented on HBASE-24722:
---------------------------------------

Merged to master. Put up PR for backport to branch-2.

> Address hbase-shell commands with unintentional return values
> -------------------------------------------------------------
>
>                 Key: HBASE-24722
>                 URL: https://issues.apache.org/jira/browse/HBASE-24722
>             Project: HBase
>          Issue Type: Improvement
>          Components: shell
>    Affects Versions: 3.0.0-alpha-1, 2.3.0
>            Reporter: Elliot Miller
>            Assignee: Elliot Miller
>            Priority: Minor
>
> There are a number of commands in hbase-shell that return values that are undocumented or otherwise do not makes sense.
> The commands that will be addressed by this ticket were found in a survey of all the hbase shell commands, https://issues.apache.org/jira/browse/HBASE-24672.
> Subtasks:
>  * Fix commands that return the number of printed lines (usually the number 1).
>  ** Affected commands (culprits): is_disabled, balancer, normalize, normalizer_switch, normalizer_enabled, catalogjanitor_switch, catalogjanitor_enabled, cleaner_chore_switch, cleaner_chore_enabled, splitormerge_switch, splitormerge_enabled, clear_deadservers, clear_block_cache
>  ** I am updating these 13 commands to either return a value that makes sense or return nil if a sensible return value doesn't exist.
>  * Fix commands that return true or false as a String
>  ** Affected commands (culprits): balance_switch, snapshot_cleanup_switch, enable_rpc_throttle, disable_rpc_throttle, enable_exceed_throttle_quota, disable_exceed_throttle_quota
>  ** I am updating these 6 commands to return ruby's TrueClass or FalseClass rather than a String



--
This message was sent by Atlassian Jira
(v8.3.4#803005)