You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/08/13 23:02:40 UTC
[GitHub] [trafficserver] serrislew opened a new pull request #8248: After parents are exhausted, serve stale content from child
serrislew opened a new pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248
After parents are exhausted, child server calls `handle_parent_died` to build the error response message. Changes made will first check if the stale cache response is returnable. If not, the server will handle the dead server/parent appropriately and build the error response message as previously explained.
Note: this only applies to parent/hierarchical caching. The changes do not affect servers who route directly to audience server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c edited a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
rob05c edited a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899882191
+1 on the PR, and also +1 on a test. This is definitely a good change, to serve stale when we can.
Specifically the test should make sure the `Cache-Control: max-stale` and records.config `max_stale_age` are being respected. Looking at the code, it looks like they are, but we should be sure.
We should also verify this behavior is in strategies and the parent_select plugin. Those of us talking about unifying the parent and non-parent paths in HttpTransact may also need to be aware of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-908525327
[add whitelist serrislew]
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
serrislew removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899717358
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-898983975
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-910783731
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-915624252
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899878678
Please write an autest for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c edited a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
rob05c edited a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899882191
+1 on the PR, and also +1 on a test. This is definitely a good change, to serve stale when we can.
Specifically the test should make sure the `Cache-Control: max-stale` and records.config `max_stale_age` are being respected. Looking at the code, it looks like they are, but we should be sure.
We should also verify this behavior is in strategies and the parent_select plugin. Those of us talking about unifying the parent and non-parent paths in HttpTransact may also need to be aware of this. You don't need to worry about those, but I'll try to remember to bring it up at our next NextHop meeting, and/or verify and/or make an issue if they aren't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899882191
+1 on the PR, and also +1 on a test. This is definitely a good change, to serve stale when we can.
We should also verify this behavior is in strategies and the parent_select plugin. Those of us talking about unifying the parent and non-parent paths in HttpTransact may also need to be aware of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
vmamidi removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-932393873
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-917097927
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-898983975
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-898983975
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 commented on a change in pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
dragon512 commented on a change in pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#discussion_r702096078
##########
File path: tests/gold_tests/proxy_protocol/proxy_serve_stale.test.py
##########
@@ -0,0 +1,106 @@
+'''
+Test child proxy serving stale content when parents are exhausted
+'''
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+def setPid(event):
+ Test.Env['SERVERPID'] = str(event.object.pid())
+
+
+Test.ContinueOnFail = True
+# Set up hierarchical caching processes
+ts_child = Test.MakeATSProcess("ts_child")
+ts_parent = Test.MakeATSProcess("ts_parent")
+server = Test.MakeOriginServer("server")
+ts_parent.RunningEvent.Connect(setPid)
+
+Test.testName = "STALE"
+
+# Request from client
+request_header = {"headers":
+ "GET / HTTP/1.1\r\nHost: localhost\r\n\r\n",
+ "timestamp": "1469733493.993",
+ "body": ""}
+# Expected response from the origin server
+response_header = {"headers":
+ "HTTP/1.1 200 OK\r\nConnection: close\r\nCache-Control: max-age=10,public\r\n\r\n",
+ "timestamp": "1469733493.993",
+ "body": "CACHED"}
+
+# add request/response
+server.addResponse("sessionlog.log", request_header, response_header)
+
+# Config child proxy to route to parent proxy
+ts_child.Disk.records_config.update({
+ 'proxy.config.diags.debug.enabled': 1,
+ 'proxy.config.diags.debug.tags': 'http|remap|parent|host',
+ 'proxy.config.http.cache.max_stale_age': 20,
+})
+ts_child.Disk.parent_config.AddLine(
+ 'dest_domain=. parent="localhost:{0}" round_robin=consistent_hash go_direct=false'.format(ts_parent.Variables.port)
+)
+ts_child.Disk.remap_config.AddLine(
+ 'map http://localhost:{0} http://localhost:{1}'.format(ts_child.Variables.port, server.Variables.Port)
+)
+
+# Config parent proxy to route to server
+ts_parent.Disk.records_config.update({
+ 'proxy.config.diags.debug.enabled': 1,
+ 'proxy.config.diags.debug.tags': 'http|remap|parent',
+ 'proxy.config.http.cache.max_stale_age': 20,
+})
+ts_parent.Disk.remap_config.AddLine(
+ 'map / http://127.0.0.1:{0}'.format(server.Variables.Port)
+)
+ts_parent.Disk.remap_config.AddLine(
+ 'map http://localhost:{0} http://localhost:{0}'.format(server.Variables.Port)
+)
+
+# Request content to cache in parent proxy
+curl_request_running = (
+ 'curl -s -v http://localhost:{0};' # miss
Review comment:
I provided a slightly cleaned-up test.
The main concern I have here is the sleep calls.. which means the test might pass or might fail based on load and stuff we cannot control on the test server. Do we have a log file item we can look for and chain the curl commands with a isReady logic when the log file has a certain message defined to make this test more deterministic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-903147216
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-903147216
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#discussion_r702168483
##########
File path: tests/gold_tests/proxy_protocol/proxy_serve_stale.test.py
##########
@@ -0,0 +1,106 @@
+'''
+Test child proxy serving stale content when parents are exhausted
+'''
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+def setPid(event):
+ Test.Env['SERVERPID'] = str(event.object.pid())
+
+
+Test.ContinueOnFail = True
+# Set up hierarchical caching processes
+ts_child = Test.MakeATSProcess("ts_child")
+ts_parent = Test.MakeATSProcess("ts_parent")
+server = Test.MakeOriginServer("server")
+ts_parent.RunningEvent.Connect(setPid)
+
+Test.testName = "STALE"
+
+# Request from client
+request_header = {"headers":
+ "GET / HTTP/1.1\r\nHost: localhost\r\n\r\n",
+ "timestamp": "1469733493.993",
+ "body": ""}
+# Expected response from the origin server
+response_header = {"headers":
+ "HTTP/1.1 200 OK\r\nConnection: close\r\nCache-Control: max-age=10,public\r\n\r\n",
+ "timestamp": "1469733493.993",
+ "body": "CACHED"}
+
+# add request/response
+server.addResponse("sessionlog.log", request_header, response_header)
+
+# Config child proxy to route to parent proxy
+ts_child.Disk.records_config.update({
+ 'proxy.config.diags.debug.enabled': 1,
+ 'proxy.config.diags.debug.tags': 'http|remap|parent|host',
+ 'proxy.config.http.cache.max_stale_age': 20,
+})
+ts_child.Disk.parent_config.AddLine(
+ 'dest_domain=. parent="localhost:{0}" round_robin=consistent_hash go_direct=false'.format(ts_parent.Variables.port)
+)
+ts_child.Disk.remap_config.AddLine(
+ 'map http://localhost:{0} http://localhost:{1}'.format(ts_child.Variables.port, server.Variables.Port)
+)
+
+# Config parent proxy to route to server
+ts_parent.Disk.records_config.update({
+ 'proxy.config.diags.debug.enabled': 1,
+ 'proxy.config.diags.debug.tags': 'http|remap|parent',
+ 'proxy.config.http.cache.max_stale_age': 20,
+})
+ts_parent.Disk.remap_config.AddLine(
+ 'map / http://127.0.0.1:{0}'.format(server.Variables.Port)
+)
+ts_parent.Disk.remap_config.AddLine(
+ 'map http://localhost:{0} http://localhost:{0}'.format(server.Variables.Port)
+)
+
+# Request content to cache in parent proxy
+curl_request_running = (
+ 'curl -s -v http://localhost:{0};' # miss
Review comment:
I agree that it would be best to avoid sleeps as a synchronization mechanism.
As Jason suggests, some of the logging AuTests await upon log file entries. log-field.test.py has a conditional TestRun that awaits an entry to populate the customized log file:
https://github.com/apache/trafficserver/blob/5c75a3052e1022662f06ea2b7d8139bb01e32f9b/tests/gold_tests/logging/log-field.test.py#L105
Can something like that be used? You would create a dedicated TestRun that awaits the log entry. A similar thing can be done for diags.log entries.
In theory, debug output can be awaited upon as well. We usually let the ATS process write to stdout/stderr and then use the AuTest stream mechanism for test conditions (ContainsExpression, ExcludesExpression). However that cannot be waited upon since it is in memory until the process finishes. We can, however, use the `--bind_stdout` and `--bind_stderr` traffic_server arguments and wait upon the specified file. That should be easy to do, but we don't have an example of that. (If this is done, make sure the file you specify is to the RunDirectory which will be in the sandbox.)
Thanks for contributing tests to ATS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-909691630
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-917265206
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-908525327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew closed pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
serrislew closed pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
dragon512 commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-912681243
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-908864376
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-909691630
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on a change in pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
serrislew commented on a change in pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#discussion_r698106423
##########
File path: tests/gold_tests/pluginTest/test_hooks/body_buffer.test.py
##########
@@ -99,10 +99,10 @@ def setupTS(self):
})
self._ts.Streams.stderr = Testers.ContainsExpression(
- rf"request_buffer_plugin gets the request body with length\[{self.content_length_size}\]",
+ rfr"request_buffer_plugin gets the request body with length\[{self.content_length_size}\]",
Review comment:
This was autocorrected from `autopep8` it wouldn't let me commit without making this `rfr` change... I will try `f`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-909691630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
vmamidi commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-932393873
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
serrislew removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899717358
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
dragon512 removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-912681243
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
serrislew commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-964348135
Duplicate of #8473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-908525327
[add whitelist serrislew]
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a change in pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#discussion_r696767451
##########
File path: tests/gold_tests/pluginTest/test_hooks/body_buffer.test.py
##########
@@ -99,10 +99,10 @@ def setupTS(self):
})
self._ts.Streams.stderr = Testers.ContainsExpression(
- rf"request_buffer_plugin gets the request body with length\[{self.content_length_size}\]",
+ rfr"request_buffer_plugin gets the request body with length\[{self.content_length_size}\]",
Review comment:
at least the version of python autest runs with doesn't like it:
```
rfr"request_buffer_plugin gets the request body with length\[{self.content_length_size}\]",
^
SyntaxError: invalid syntax
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-909691630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#discussion_r696715956
##########
File path: tests/gold_tests/pluginTest/test_hooks/body_buffer.test.py
##########
@@ -99,10 +99,10 @@ def setupTS(self):
})
self._ts.Streams.stderr = Testers.ContainsExpression(
- rf"request_buffer_plugin gets the request body with length\[{self.content_length_size}\]",
+ rfr"request_buffer_plugin gets the request body with length\[{self.content_length_size}\]",
Review comment:
Is rfr a thing? Doesn't seem to be in Python 3.7. I think maybe the expression string is a regular expression, so maybe this would be an option:
```
f"request_buffer_plugin gets the request body with length.{self.content_length_size}.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
serrislew commented on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899717358
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-917097927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jchassery12 commented on a change in pull request #8248: After parents are exhausted, serve stale content from child
Posted by GitBox <gi...@apache.org>.
jchassery12 commented on a change in pull request #8248:
URL: https://github.com/apache/trafficserver/pull/8248#discussion_r698106668
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -3758,7 +3758,9 @@ HttpTransact::handle_response_from_parent(State *s)
return CallOSDNSLookup(s);
Review comment:
-----BEGIN PGP PUBLIC KEY BLOCK-----
mQINBF+QvDgBEADdh09dIq1vn8xc7+yFfS9XgyvoZX6PXIbfAt3X5w7mFwqiso7+
hQeTB1Y4YBe6On89OEx7AdymPzWLXcxs5+dRDH4uY/Cr+EjVwbWOdi/ruqbvKXff
UHJVMjDvFLK+6PiIngeRfTG7MO7vxnSZSH+4Gqh1LYhuNUYccg07bc5U3AMhSDZb
nlds4d3hpSxNuxnhB+Z06qRVMSjTugsWHCzrIPQF7UrxpeznbHRzILo5zaJhpWS3
6RXtDskd+uneEksdI0tOFnibdTQBPYah0ayCjDYo1ldEaeJHjlKi8qFfxbltXZP0
u9lP+pqHqqQQ22R/yZdqZpoju8VjoObc0LV1Jqp0EM3xGL9Qj9c50ULcqXatqeQq
QpI6XfuGCw09vqBX9NXJBBoHdd3bRiuHobvJp7qFP7q4ILTun2BvaffWbRduWaNU
nt733TP9l2EzTcvfqDLG3Yhqkba+HHV3xYqNgMHupkFG5dNcKN6t+rQmwi8l+0J5
AGUElye5CiGJ0vB6S4KMmVHCM1oZmOoO35d0aZ13TYWXaS7gRz4o4eYYnFROA4qW
TWKNUi4lkFHGml3b2HE92biuQv+UVUiVDNGGbGsnRzbwQN5QXuxytxD5IHgQ3L9b
s685IEdB2Yj0bCGKYkTSsl5IoG5RkdRwEZ6REq9WRJRvk7LAWgoSaR96uwARAQAB
tENJRVRGIE9wZXJhdGlvbmFsIFZ1bG5lcmFiaWxpdHkgPG9wZXJhdGlvbmFsLXZ1
bG5lcmFiaWxpdHlAaWV0Zi5vcmc+iQJUBBMBCAA+FiEEnnobhWohE0MqxiQbAJeh
a/IzLYsFAl+QvDgCGwMFCQeGH4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ
AJeha/IzLYtotw//Uc5Jlrxh1b+pxCp9JCSl4/BfUmkRYgbiwiXtqS2NRE94JYuD
NNRVow9fDTlIkAIz953Rk6ajYAwS4jMvN6121lfudp2aazvk/uwurEkpwUjeOYOM
NntsrxCCTVVNMf79pBw868dROwm3eiFT5uene1FpQYtgohf0C9KAcAtcM3nm1AC2
9vBUdCq/JZyPNAEVcPXaUVITDbVGfPrdCLOg/0qf3rIt3djA/11e+SS67GWOXxWm
LmKobUz8AXPb+fkulbXHir1NfUXqPsV9CyJFcdi/o1qqL6pE9sh4y3I3GRp9h8zJ
tY0MXMkxSFIc37Co3FNwX8i0txo2vgIWMeUDJp82wcJRNNSSsjUxb/ES4D1GXJx9
TxGO53klY9YdcItCBrd5PjajBYVrhVY+zuqpkUg0RaRoQ8xuD/jHb0N/xg/OQZ0s
C/HQlgjv/EogBDYB6l7FawuDHkyFas83vSHWJoINRP/AYXI2CcXIkGz8hMxbwOd2
OvQJ06rbyfJ2CCBg8stFcGgDxWtzY8wIZPkBHK5Wyv6bTAapzP891F9KDxTK4QTJ
QeRPRLiA/xVMyQKwMoTpgwK0E3x6RZLw2rvqP1+z60EoJgQuie+xj/pNwy4ZiOXQ
weAHBISI/raSw5w9NGihVfA/+hIcGtCzxJeEqwf30qO3je9Rx0S5HbG2kPS5Ag0E
X5C8OAEQAO/hUuJktwfuTmBbtkpUyGEC+gDeOoa24qKWsXoPe+1K3kTWxfDLZ8Gz
ShvbOg/zwAM+fJx4BaNhys3lI+nfT1aSXjjsQIZG0hw09FKjtE4qB3251x2LbsRZ
dGDDxibtGbnRG4ZnlTh5M9ylE5WfThcMHHmfERLHTMcsNgEY5ArKuOO/obC5kOZl
PHIBUtlpC31Bf9rYhxAkHdDW6PGDiHyIv4TP9T8VCuJa9asJcLg5Vl2s7BBRBhoe
a9v62cq8A89dgt0tGIt3StZPTvCJOV2YjPlwUbLXsTvSWmo8jjKR5pOXBld/Qr4j
W89gY10cONA943kwC41Ni5muDCADjhPEuFUoCdsTcE3qpYKtUDf2dz75rNaN6pxD
HO5shh/ezQhqy0F8KWbCI9BmqUh84edxkkmQdBjYDOM/5M+lrbZdEvOYQULT+0ME
LYqUDgc8XjnmjNsJG6njmk30zu4q9mzgpGBHeW2z7VUuaVfnbAjxB12kd07oo5Jz
xfpY3CSrryi2e0GPZGuS+7CH2faHMsMTOoJsEapuesgV/a83UqmB+dNW4tRkt8c2
v+M70/V9RowLAel25snB2uA+F6sQugXRK0o2Q+TpckSrw9Rt1AYx0FSOraz9Y5nv
w6oxnMazBZB0d4RpWk73GfSvPPzra0lyQ2KZgl+VMosZ0+xW18nTABEBAAGJAjwE
GAEIACYWIQSeehuFaiETQyrGJBsAl6Fr8jMtiwUCX5C8OAIbDAUJB4YfgAAKCRAA
l6Fr8jMtiySMD/wMRF0dhmHh0nceD98XAXubNTj7gpIlSYLGnaUNkMreDL+MuwFO
35pHOtv176MB6DqfJS0C1xGp0vvLBWEtf6zI3ZdYpBB+SB1FKx3C1AddGCao2Ba4
7JcNJXVIHIZ75nlOxV2b6WE+7rhUrEAOtl6dI9/DX9nugCSakFZKIqzGe8hEaRNL
/CnE18hlyZ4mGuhnMYuQYkl3jPZ1uK2zmgquidRZSqQyEOolJg7QnGeAoLEPdCRK
WW/nb0B3owjZ/n3Q4h0Cwht1lM06TxNyV3JFzbnAZ05tbXiN8OVx/6gSS6qbF1RJ
HuL5m8CU7ycpCnlba4er4obQxHNXge9Zs7A9IDZm/JN465l4Ishkj+Gz5a4gwkMB
A7CNLvMZcOyIKJtL0cuJ8Rr7GFNp/nwkR5oH3zizS6eT7HnYA1CZOx5t3iETwNQm
OZ8qqtRgwSd1Pl/ZSSj2qqeN9pFXiSkYpNVxvcQWWN1Gpa+QYY+3daG1QRnbinqG
rgZWPB4Q/V4PI3VsAp5e22hRd7D45A72YH2D3gS3Ennh5vP9mIEl8p5U9BBf6yrs
2MrsYUIjQvaF49hq0QNK8K7wKw1K7CdWWT3i96SA51ynTGjn/siMW9krqAd/kuH5
cQWQnreE772XVGQLkqW77eRtqu+OsNQav2lBAcY5jmS/MAauOo82FlANBA==
=mQQc
-----END PGP PUBLIC KEY BLOCK-----
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org