[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #10: [FLINK-26290] Introduce serviceAccount as direct field, remove taskSlots

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #10:
URL: https://github.com/apache/flink-kubernetes-operator/pull/10#discussion_r811529382



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java
##########
@@ -72,6 +72,12 @@ public static Configuration getEffectiveConfig(FlinkDeployment flinkApp) {
                         KubernetesConfigOptions.ServiceExposedType.ClusterIP);
             }
 
+            if (spec.getServiceAccount() != null) {

Review comment:
       Maybe we need to set `KubernetesConfigOptions#KUBERNETES_SERVICE_ACCOUNT` here. If the user wants to give the TaskManager pods less permissions, then they should create different service accounts for both and configure them in jobManager and taskManager fields.
   
   Note: The reason why we need to configure service account for TaskManager pod is about the Kubernetes HA. TaskManagers retrieve leader information from K8s ConfigMap.
   
   The e2e test is failing also because of this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org