You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/31 13:42:03 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #15110: Allow pathlib.Path in DagBag and various utils

kaxil commented on a change in pull request #15110:
URL: https://github.com/apache/airflow/pull/15110#discussion_r604908035



##########
File path: airflow/models/dagbag.py
##########
@@ -450,7 +453,8 @@ def collect_dags(
         # Used to store stats around DagBag processing
         stats = []
 
-        dag_folder = correct_maybe_zipped(dag_folder)
+        # Ensure dag_folder is a str -- it may have been a pathlib.Path
+        dag_folder = correct_maybe_zipped(str(dag_folder))

Review comment:
       Should we also let `correct_maybe_zipped` accept Pathlib too and convert it to str if needed in the function itself ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org