You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/01/08 08:26:30 UTC

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12178

to look at the new patch set (#2).

Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................

KUDU-2656: pass IOContext to ValidateDeltaOrder

Previously, checksum errors that occurred during calls to the debug-only
function ValidateDeltaOrder() would lead to a DCHECK failure. This patch
plumbs an IOContext to these calls to avoid this and adds a regression
test for such cases.

Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
---
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
6 files changed, 55 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/12178/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)