[GitHub] [maven] arturobernalg commented on a change in pull request #583: [MNG-7299] - Simplify conditional expression

[GitBox <gi...@apache.org>]

arturobernalg commented on a change in pull request #583:
URL: https://github.com/apache/maven/pull/583#discussion_r728625408



##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/PropertyProfileActivator.java
##########
@@ -97,13 +97,13 @@ public boolean isActive( Profile profile, ProfileActivationContext context, Mode
             // we have a value, so it has to match the system value...
             boolean result = propValue.equals( sysValue );
 
-            return reverseValue ? !result : result;
+            return reverseValue != result;
         }
         else
         {
             boolean result = StringUtils.isNotEmpty( sysValue );

Review comment:
       true. Changed.
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org