You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/07/01 12:47:03 UTC
Review Request 12205: message(s) made more identifying for the error location
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12205/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-2162
Repository: cloudstack-git
Description
-------
make several messages made more distict and readible so identifying the error location is easier.
Diffs
-----
server/src/com/cloud/storage/StorageManagerImpl.java 138c6d7
Diff: https://reviews.apache.org/r/12205/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request 12205: message(s) made more identifying for the
error location
Posted by Prasanna Santhanam <ts...@apache.org>.
On Tue, Jul 02, 2013 at 09:18:42AM +0200, Daan Hoogland wrote:
> ok,
>
> If any of those seem fine to me, should I hit ship it? I can not
> submit!
You can hit Ship it with your comments where applicable. That's good
indication for another committer to proceed with the push to the repo.
--
Prasanna.,
------------------------
Powered by BigRock.com
Re: Review Request 12205: message(s) made more identifying for the
error location
Posted by Daan Hoogland <da...@gmail.com>.
ok,
If any of those seem fine to me, should I hit ship it? I can not submit!
On Tue, Jul 2, 2013 at 8:52 AM, Prasanna Santhanam <ts...@apache.org> wrote:
> On Mon, Jul 01, 2013 at 06:30:57PM +0200, Daan Hoogland wrote:
> > Is this request of yours still valid? happy to do a review or a half.
>
> Yes please, still some stuff not in Submitted state. Thanks for your
> help
>
> >
> >
> > On Mon, Jul 1, 2013 at 4:53 PM, Prasanna Santhanam <ts...@apache.org>
> wrote:
> >
> > > On Mon, Jul 01, 2013 at 04:49:53PM +0200, Hugo Trippaers wrote:
> > > > Hah,
> > > >
> > > > you beat me to it by seconds prassana ;-)
> > >
> > > Hehe. Need help with some others though. Ones by Laszlo and Dave
> > > Brosius esp are simpler to review since they touch java issues. Anyone
> > > willing to help?
> > >
> > > https://reviews.apache.org/users/kocka/
> > > https://reviews.apache.org/users/mebigfatguy/
> > >
> > > --
> > > Prasanna.,
> > >
> > > ------------------------
> > > Powered by BigRock.com
> > >
> > >
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
>
Re: Review Request 12205: message(s) made more identifying for the
error location
Posted by Prasanna Santhanam <ts...@apache.org>.
On Mon, Jul 01, 2013 at 06:30:57PM +0200, Daan Hoogland wrote:
> Is this request of yours still valid? happy to do a review or a half.
Yes please, still some stuff not in Submitted state. Thanks for your
help
>
>
> On Mon, Jul 1, 2013 at 4:53 PM, Prasanna Santhanam <ts...@apache.org> wrote:
>
> > On Mon, Jul 01, 2013 at 04:49:53PM +0200, Hugo Trippaers wrote:
> > > Hah,
> > >
> > > you beat me to it by seconds prassana ;-)
> >
> > Hehe. Need help with some others though. Ones by Laszlo and Dave
> > Brosius esp are simpler to review since they touch java issues. Anyone
> > willing to help?
> >
> > https://reviews.apache.org/users/kocka/
> > https://reviews.apache.org/users/mebigfatguy/
> >
> > --
> > Prasanna.,
> >
> > ------------------------
> > Powered by BigRock.com
> >
> >
--
Prasanna.,
------------------------
Powered by BigRock.com
Re: Review Request 12205: message(s) made more identifying for the
error location
Posted by Daan Hoogland <da...@gmail.com>.
Is this request of yours still valid? happy to do a review or a half.
On Mon, Jul 1, 2013 at 4:53 PM, Prasanna Santhanam <ts...@apache.org> wrote:
> On Mon, Jul 01, 2013 at 04:49:53PM +0200, Hugo Trippaers wrote:
> > Hah,
> >
> > you beat me to it by seconds prassana ;-)
>
> Hehe. Need help with some others though. Ones by Laszlo and Dave
> Brosius esp are simpler to review since they touch java issues. Anyone
> willing to help?
>
> https://reviews.apache.org/users/kocka/
> https://reviews.apache.org/users/mebigfatguy/
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
>
Re: Review Request 12205: message(s) made more identifying for the
error location
Posted by Prasanna Santhanam <ts...@apache.org>.
On Mon, Jul 01, 2013 at 04:49:53PM +0200, Hugo Trippaers wrote:
> Hah,
>
> you beat me to it by seconds prassana ;-)
Hehe. Need help with some others though. Ones by Laszlo and Dave
Brosius esp are simpler to review since they touch java issues. Anyone
willing to help?
https://reviews.apache.org/users/kocka/
https://reviews.apache.org/users/mebigfatguy/
--
Prasanna.,
------------------------
Powered by BigRock.com
Re: Review Request 12205: message(s) made more identifying for the error location
Posted by Hugo Trippaers <hu...@trippaers.nl>.
Hah,
you beat me to it by seconds prassana ;-)
Cheers,
Hugo
On Jul 1, 2013, at 4:48 PM, "Prasanna Santhanam" <ts...@apache.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12205/#review22598
> -----------------------------------------------------------
>
> Ship it!
>
>
> 216e374 -> 4.2
> 639592f -> master
>
> - Prasanna Santhanam
>
>
> On July 1, 2013, 10:46 a.m., daan Hoogland wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/12205/
>> -----------------------------------------------------------
>>
>> (Updated July 1, 2013, 10:46 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Bugs: CLOUDSTACK-2162
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> make several messages made more distict and readible so identifying the error location is easier.
>>
>>
>> Diffs
>> -----
>>
>> server/src/com/cloud/storage/StorageManagerImpl.java 138c6d7
>>
>> Diff: https://reviews.apache.org/r/12205/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> daan Hoogland
>>
>>
>
Re: Review Request 12205: message(s) made more identifying for the error
location
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12205/#review22598
-----------------------------------------------------------
Ship it!
216e374 -> 4.2
639592f -> master
- Prasanna Santhanam
On July 1, 2013, 10:46 a.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12205/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 10:46 a.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-2162
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> make several messages made more distict and readible so identifying the error location is easier.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 138c6d7
>
> Diff: https://reviews.apache.org/r/12205/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 12205: message(s) made more identifying for the error
location
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12205/#review22596
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Trippaers
On July 1, 2013, 10:46 a.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12205/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 10:46 a.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-2162
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> make several messages made more distict and readible so identifying the error location is easier.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 138c6d7
>
> Diff: https://reviews.apache.org/r/12205/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>