[GitHub] [spark] srowen commented on a change in pull request #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places
URL: https://github.com/apache/spark/pull/24368#discussion_r275158773
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -1303,4 +1303,9 @@ package object config {
     .doc("Staging directory used while submitting applications.")
     .stringConf
     .createOptional
+
+  private[spark] val BUFFER_PAGESIZE = ConfigBuilder("spark.buffer.pageSize")
+    .bytesConf(ByteUnit.BYTE)
 
 Review comment:
   I was going to say this needs a default, but it looks like the default in non-test code is not a single value, and different tests want different defaults. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org