You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/12/19 16:58:06 UTC

[GitHub] [jackrabbit-oak] jelmini commented on a diff in pull request #800: Issue/oak 10022

jelmini commented on code in PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1052432848


##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tar/TarWriter.java:
##########
@@ -183,7 +183,14 @@ void flush() throws IOException {
             }
 
             if (doFlush) {
-                archive.flush();
+                archive.flush(() -> {
+                    try {
+                        writeBinaryReferences();

Review Comment:
   Do you know how much overhead this would introduce on each flush? Could this be problematic? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org