You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kosiew (via GitHub)" <gi...@apache.org> on 2025/10/01 13:36:55 UTC

Re: [PR] Freeze PyO3 wrappers & introduce interior mutability to avoid PyO3 borrow errors [datafusion-python]

kosiew commented on code in PR #1253:
URL: https://github.com/apache/datafusion-python/pull/1253#discussion_r2394619426


##########
python/tests/test_expr.py:
##########
@@ -53,6 +54,10 @@
     ensure_expr_list,
 )
 
+# Avoid passing boolean literals positionally (FBT003). Use a named constant
+# so linters don't see a bare True/False literal in a function call.
+_TRUE = True

Review Comment:
   > whitelist functions like lit
   
   I'll implement this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org