[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

[hvanhovell <gi...@git.apache.org>]

Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13706#discussion_r67460021
  
    --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -97,6 +97,9 @@ statement
         | CREATE TEMPORARY? FUNCTION qualifiedName AS className=STRING
             (USING resource (',' resource)*)?                              #createFunction
         | DROP TEMPORARY? FUNCTION (IF EXISTS)? qualifiedName              #dropFunction
    +    | CREATE TEMPORARY MACRO macroName=identifier
    +        '('(columns=colTypeList)?')' expression                        #createMacro
    --- End diff --
    
    NIT: get rid of the parenthesis, you can also just use the `colTypeList?`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org