You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by alter-xp <no...@github.com.INVALID> on 2022/05/30 06:34:41 UTC
[apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Introduce CSI-NN2 Compute Library into TVM to accelerate the inference performance of RISC-V CPU with Vector Extension.
You can view, comment on, or merge this pull request online at:
https://github.com/apache/tvm-rfcs/pull/75
-- Commit Summary --
* RFC-CSI-NN2-Integration
-- File Changes --
A rfcs/0075_RISC-V_CSI-NN2_Intergration.md (171)
-- Patch Links --
https://github.com/apache/tvm-rfcs/pull/75.patch
https://github.com/apache/tvm-rfcs/pull/75.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75
You are receiving this because you are subscribed to this thread.
Message ID: <apache/tvm-rfcs/pull/75@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by Andrew Reusch <no...@github.com.INVALID>.
Merged #75 into main.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#event-6816322214
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by alter-xp <no...@github.com.INVALID>.
> This is fantastic, thank you! We're excited to hear about the results for MLPerf. My main comment is mostly concerned about documentation. I'm glad the build instructions are included with the RFC, but I'd like to see the inclusion of documentation about how to configure, build, and use the platform be explicitly updated and included.
Thanks for comments. we provide a documentation in [PR for TVM](https://github.com/apache/tvm/commit/e1f33130e847d6c29b2b4c4e5eba3ca37c89f8cd#diff-330c6f2d08738b9f7e5880b9fe245798559202d161db73243533525100a7d459). But I'm not sure whether these contents need to be completely written in RPC
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#issuecomment-1147389744
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by alter-xp <no...@github.com.INVALID>.
> ok, then for CI do you plan to e.g. expand our `ci_qemu` Docker image to additionally contain this custom qemu? (this involves committing a change to `docker/`, then pinging a committer to update the version of the image used)
Thanks for advice, we will add it. but I have no experience about this. Is there any relevant process?
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#issuecomment-1152099008
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by alter-xp <no...@github.com.INVALID>.
@areusch [a tracking issue](https://github.com/apache/tvm/issues/11506) is ready. I will keep updating it.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#issuecomment-1157154054
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by Andrew Reusch <no...@github.com.INVALID>.
@alter-xp we have some:
- about the CI environment: https://tvm.apache.org/docs/contribute/pull_request.html#ci-environment
- about building docker containers locally: https://github.com/apache/tvm/blob/main/docker/README.md
we need to write that up :/
the basics are:
1. submit a PR which only modifies docker/ scripts. the CI will rebuild docker containers and then run through using the newly-rebuilt containers.
2. ping a committer to publish the built images to the `tlcpack` dockerhub org
3. submit another PR which modifies jenkins/Jenkinsfile.j2 (and run generate.py there to modify Jenkinsfile) to reference the newly-pushed containers. you can also add tests which depend on the newly-added dependencies here.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#issuecomment-1152720214
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by Chris Hoge <no...@github.com.INVALID>.
This is fantastic, thank you! We're excited to hear about the results for MLPerf. My main comment is mostly concerned about documentation. I'm glad the build instructions are included with the RFC, but I'd like to see the inclusion of documentation about how to configure, build, and use the platform be explicitly updated and included.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#issuecomment-1142328577
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by alter-xp <no...@github.com.INVALID>.
@areusch Thanks a lot. let me update the image.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#issuecomment-1153408149
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>
Re: [apache/tvm-rfcs] [RFC][Backend] RFC-CSI-NN2-Integration (PR #75)
Posted by Andrew Reusch <no...@github.com.INVALID>.
thanks @alter-xp, the PR is now merged! please open an RFC tracking issue and list out the PRs we can expect there, then we can proceed on the CI changes.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/75#issuecomment-1156983012
You are receiving this because you are subscribed to this thread.
Message ID: <ap...@github.com>